Re: [PATCH 6/7] xen/guest_access: Consolidate guest access helpers in xen/guest_access.h

[Julien Grall <julien@xxxxxxx>]

On 29/04/2020 15:54, Jan Beulich wrote:
> On 29.04.2020 16:13, Julien Grall wrote:
> > So can you please have another and explain how the line can be drawn with just 
> > two architectures in place.
> There are abstract considerations that can be used to draw the
> line, as well as knowledge of people on architectures Xen doesn't
> run on, but where one can - with such knowledge - extrapolate how
> it would want to be implemented.
>
> I don't think the question at this point is where to draw the
> line, but whether to have asm-generic/ in the first place.
Well the two come together. You can't add a new directory with no clear 
view how this is going to be used.
At the moment, this would result at best bikeshedding because 
developpers may have a different opinion on how a new architecture would 
be implemented in Xen.
If you have a 3rd architectures then it would be easier to argue the 
header should be added in asm-generic/ or xen/:
   - asm-generic/ should be used if 2 of the architectures are using 
the same interface
   - xen/ should be if the 3 architectures are using the same interface

Cheers,

--
Julien Grall