[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py


  • To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Mon, 8 Jun 2020 11:39:43 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>
  • Delivery-date: Mon, 08 Jun 2020 11:39:50 +0000
  • Ironport-sdr: AyeaVFUQ6CfyNQPiZMHUlPt6zuKwSokVMJHFmhlqzLVffoiDp5XdMSrOd1wZcZhNjJZqyiS6K1 lyzmJwJ6mxWSOiWkoUvpE4B0a52XQtSAPrFBeWSfqolCxGDnEk/LI0ZXUgS3C96pheahfZKhEM 5h1sQkLH+wtYocHnJsYHXsbZKbnw6t4mrPEs9Yc+oXAMxUR+xivNmAW7yEUU2eMPeKIYmkLVEU Z3eL5fo2KQK8V/gXnPjrtT5ntt3l0WU1NSzYoNfiiuke8HmBEq9/cBBbvj9z9/8si1iU4aTCSg 1EY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWPB0FRC5n06e/7UW7VAlSJqYdHajOeT+A
  • Thread-topic: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
> 
> Since the golang bindings are now set to be re-generated whenever a
> change is made to tools/libxl/libxl_types.idl, the call to go fmt in
> gengotypes.py results in a dirty git tree for users without go
> installed.
> 
> As an immediate fix, just remove the call to go fmt from gengotypes.py.
> While here, make sure the DO NOT EDIT comment and package declaration
> remain formatted correctly. All other generated code is left
> un-formatted for now.
> 
> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

With one note: git complains that the resulting patch introduces loads of 
trailing whitespace.  I went though gengotypes.py and essentially did `s/ 
\n/\n/g`.  With your permission I’ll fold that (and the resulting patches) into 
this before checking it in.

 -George


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.