[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py


  • To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Mon, 8 Jun 2020 14:15:40 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>
  • Delivery-date: Mon, 08 Jun 2020 14:15:50 +0000
  • Ironport-sdr: hcNAetMG/KmWblZbLN0Jqp3lG+aPtcynRFpY875hU77cZmwztVpB2xYNV39hT/mBMS5w1CcitI rl7OkATJ/aYF6DQhoQ4VSvho9+gujE+YxyWAUMrPe98GY1LbLc37U0oqUGROfjXhiC0V2DHLAG eSonSxVrxPpEBu5qVCBuaYoPNRfHCc4/dmwVtk3GKtW6l1XTKS8mcyVh8dCW4fENfZLpWHo3WC 3L9KtlSJSObM+nRrU86ln8Z2y5885v2o848f5zfxsEs4j/i+vCwa+8A9G0D9Kt7gTbfjLfruHT Xdc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWPB0FRC5n06e/7UW7VAlSJqYdHajOeT+AgAArkwA=
  • Thread-topic: [PATCH for-4.14] golang/xenlight: remove call to go fmt in gengotypes.py

CC’ing release manager

> On Jun 8, 2020, at 12:39 PM, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
> 
>> 
>> On Jun 6, 2020, at 5:10 PM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>> 
>> Since the golang bindings are now set to be re-generated whenever a
>> change is made to tools/libxl/libxl_types.idl, the call to go fmt in
>> gengotypes.py results in a dirty git tree for users without go
>> installed.
>> 
>> As an immediate fix, just remove the call to go fmt from gengotypes.py.
>> While here, make sure the DO NOT EDIT comment and package declaration
>> remain formatted correctly. All other generated code is left
>> un-formatted for now.
>> 
>> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
> 
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Paul, this is a fix to the build system that only affects the formatting of 
some generated code.  (At the moment, the generated code will look differently 
depending on whether you have golang installed or not.)

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.