[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/displif: Protocol version 2

  • To: "paul@xxxxxxx" <paul@xxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Wed, 8 Jul 2020 05:59:32 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkZben1qMnLj1VM1VKV6UvVAcUqY5BtSCC6VYfncShA=; b=UwerMGGjATM/T7Jw7/pg71wHLm6WERkCO++Daj/8E/Iyj6QxtS6dDYjwuDLUuXvGo50o+HiEPe1xQhfbSIlX+HfJVHp5p3ktJe8QU2umZZVtgWqdM51UgQxDlYtvPtcM3C4Q5wgHLO1I5/kd6AyODhZOn4i3KatO09gRC3UVqy5Xuy+dHiJYSb3oE/RA5cUWzc9B5O96uClEHCdWU3Oo7MOqOvTb6uXlfM+/Eod6yOZvXwkDj5KYeqP006hXsmvMDQd0V8xo9ZXT2oBZ63oFziFnGjulwlnNRVR3DzIPIsBXxtAgUIcsNwGpQYi9tHNSXUN68HJkKcm8T3lpdaRPxg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=du/7gS0JjyMYmY2QnHsRiWDq8G4QGnJsFOXsRpIzraxavp7tMBNfePkftRhiVlPcmz1L3pNdEei3nx0B0pUX9cNAks7RTHdIWJbrHOCz49zTtoxqS4GFonmjXEl3Tr7VFWoRN2YE9I39Q3P3NmH7SGsUfrnILhkcTxEzTAz0QelSy88uReNv/KcCbDK0QQ+uNEyFeDWJaVrHyWOHeqvzX+qVfwoksdfUX3TwU3d7nGU3tzbmVCEcUmEDIwzbljIojOcZ2MOghw9haGavl3FKUzflEuQ8u2geei9EfuICVdcmJxCtiavF3OmzFq1MuYazEaEJf9vsGfXXCSGQ9A+iuQ==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com;
  • Cc: Jürgen Groß <jgross@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 08 Jul 2020 05:59:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWT3f2pfc1d0tAak69A/eTMH1j5qjyit6AgAAWp4CAAUH0AIAACwsAgAAL5oCACUCJAA==
  • Thread-topic: [PATCH v2] xen/displif: Protocol version 2

Hi, Paul!

On 7/2/20 11:42 AM, Jürgen Groß wrote:
> On 02.07.20 09:59, Oleksandr Andrushchenko wrote:
>> On 7/2/20 10:20 AM, Jürgen Groß wrote:
>>> On 01.07.20 14:07, Oleksandr Andrushchenko wrote:
>>>> On 7/1/20 1:46 PM, Jürgen Groß wrote:
>>>>> On 01.07.20 09:19, Oleksandr Andrushchenko wrote:
>>>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>>>> 1. Add protocol version as an integer
>>>>>> Version string, which is in fact an integer, is hard to handle in the
>>>>>> code that supports different protocol versions. To simplify that
>>>>>> also add the version as an integer.
>>>>>> 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
>>>>>> There are cases when display data buffer is created with non-zero
>>>>>> offset to the data start. Handle such cases and provide that offset
>>>>>> while creating a display buffer.
>>>>>> 3. Add XENDISPL_OP_GET_EDID command
>>>>>> Add an optional request for reading Extended Display Identification
>>>>>> Data (EDID) structure which allows better configuration of the
>>>>>> display connectors over the configuration set in XenStore.
>>>>>> With this change connectors may have multiple resolutions defined
>>>>>> with respect to detailed timing definitions and additional properties
>>>>>> normally provided by displays.
>>>>>> If this request is not supported by the backend then visible area
>>>>>> is defined by the relevant XenStore's "resolution" property.
>>>>>> If backend provides extended display identification data (EDID) with
>>>>>> XENDISPL_OP_GET_EDID request then EDID values must take precedence
>>>>>> over the resolutions defined in XenStore.
>>>>>> 4. Bump protocol version to 2.
>>>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>>>> Thank you, do you want me to prepare the same for the kernel so
>>>> you have it at hand when the time comes?
>>> It should be added to the kernel only when really needed (i.e. a user of
>>> the new functionality is showing up).
>> We have a patch for that which adds EDID to the existing PV DRM frontend,
>> so while upstreaming those changes I will also include changes to the 
>> protocol
>> in the kernel series: for that we need the header in Xen tree first, right?
> Yes.
Is it possible that we have this change in the release please?

This is not used by any piece of code in Xen, so it won't hurt anything.

But I need this change in so I can proceed with the Linux kernel part:

we would like to upstream the relevant EDID change to the display

frontend driver and without the header in Xen tree we are stuck

Thank you in advance,


> Juergen



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.