[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] x86/mce: bring hypercall subop compat checking in sync again

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 14 Jul 2020 13:19:00 +0200
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Jul 2020 11:19:12 +0000
  • Ironport-sdr: dKvtN1W44Xs5OPJjtNdDWaeoDcRLea9VIVmnYr3g6VwRy0IdJIg9VyRU7czC6pkBts3fj5ptR/ elVIgypijoulLpE33wL6LdkUb3HLI/0Mg7/vQQBQ2SVrzMlE0gX5VhohOg9+X2n8bAZOoE44Sl jtjMcQT0QnbzDEgG4fEJDjWZBavMRBtTJx+5gHrI5aat7emVe438Oh1grqKsfVUTJBqz9qxNH9 7seSSqxxnd9vwZVTB0SUBxV01VHz0bZiwR7ZmI6jv7QwCfUeNRWKuRuuUGglz+a4Qs4FskQnOR 62A=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jul 01, 2020 at 12:26:54PM +0200, Jan Beulich wrote:
> Use a typedef in struct xen_mc also for the two subops "manually"
> translated in the handler, just for consistency. No functional
> change.

I'm slightly puzzled by the fact that mc_fetch is marked as needs
checking while mc_physcpuinfo is marked as needs translation,
shouldn't both be marked as needing translation? (since both need to
handle a guest pointer using XEN_GUEST_HANDLE)

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.