[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] bitmap: move to/from xenctl_bitmap conversion helpers

Hi Jan,

On 15/07/2020 11:40, Jan Beulich wrote:
A subsequent change will exclude domctl.c from getting built for a
particular configuration, yet the two functions get used from elsewhere.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/common/bitmap.c
+++ b/xen/common/bitmap.c
@@ -9,6 +9,9 @@
  #include <xen/errno.h>
  #include <xen/bitmap.h>
  #include <xen/bitops.h>
+#include <xen/cpumask.h>
+#include <xen/domain.h>

The inclusion of xen/domain.h in common/bitmap.c seems a bit odd to me. Would it make sense to move the prototype of bitmap_to_xenctl_bitmap()/xenctl_bitmap_to_bitmap() to bitmap.h?


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.