Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

On Tue, Aug 4, 2020 at 10:17 AM Wei Liu <wl@xxxxxxx> wrote:
>
> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote:
> > While this doesn't address the real problem I've run into (attempting to
> > update r/o source files), not recursing into tools/golang/xenlight/ is
> > enough to fix the build for me for the moment. I don't currently see why
> > 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found
> > it necessary to invoke this build step unconditionally.
> >
>
> Perhaps an oversight?

This is intentional, and I think the commit message in 60db5da62ac0
("libxl: Generate golang bindings in libxl Makefile") explains the
reasoning well. But, to summarize, CONFIG_GOLANG is only used to
control the bindings actually being compiled (i.e. with `go build`).
However, we always want the code generation script
(tools/golang/xenlight/gengotypes.py) to run if e.g.
tools/libxl/libxl_types.idl is modified.

I hope this helps.

-NR