[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libxl: avoid golang building without CONFIG_GOLANG=y



On 04.08.2020 17:22, Nick Rosbrook wrote:
> On Tue, Aug 4, 2020 at 10:17 AM Wei Liu <wl@xxxxxxx> wrote:
>>
>> On Mon, Aug 03, 2020 at 10:06:32AM +0200, Jan Beulich wrote:
>>> While this doesn't address the real problem I've run into (attempting to
>>> update r/o source files), not recursing into tools/golang/xenlight/ is
>>> enough to fix the build for me for the moment. I don't currently see why
>>> 60db5da62ac0 ("libxl: Generate golang bindings in libxl Makefile") found
>>> it necessary to invoke this build step unconditionally.
>>>
>>
>> Perhaps an oversight?
> 
> This is intentional, and I think the commit message in 60db5da62ac0
> ("libxl: Generate golang bindings in libxl Makefile") explains the
> reasoning well. But, to summarize, CONFIG_GOLANG is only used to
> control the bindings actually being compiled (i.e. with `go build`).
> However, we always want the code generation script
> (tools/golang/xenlight/gengotypes.py) to run if e.g.
> tools/libxl/libxl_types.idl is modified.
> 
> I hope this helps.

Not really - I'm still not seeing the "why" behind this behavior. I.e.
why build _anything_ that's not used further in the build, nor getting
installed? Also if (aiui) you effectively object to the change that
Wei has given his ack for, would you mind providing an alternative fix
for the problem at hand?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.