RE: [PATCH] tools/hotplug/Linux: don't needlessly use non-standard features in vif-bridge

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 01 September 2020 11:11
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Paul Durrant 
> <paul@xxxxxxx>
> Subject: [PATCH] tools/hotplug/Linux: don't needlessly use non-standard 
> features in vif-bridge
> 
> We're not after any "fall-through" behavior here. Replace the constructs
> with ones understood by all conforming shells, including older bash
> (problem observed with 3.1.51(1)).
> 
> Fixes: b51715f02bf9 ("tools/hotplug/Linux: remove code duplication in 
> vif-bridge")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

If using fall-through is indeed a problem then vif-route will need a similar 
modification I think.

  Paul

> --- a/tools/hotplug/Linux/vif-bridge
> +++ b/tools/hotplug/Linux/vif-bridge
> @@ -77,16 +77,12 @@ then
>  fi
> 
>  case "$command" in
> -    add)
> -        ;&
> -    online)
> +    add|online)
>          setup_virtual_bridge_port "$dev"
>          set_mtu "$bridge" "$dev" "$type_if"
>          add_to_bridge "$bridge" "$dev"
>          ;;
> -    remove)
> -        ;&
> -    offline)
> +    remove|offline)
>          remove_from_bridge "$bridge" "$dev"
>          ;;
>  esac