Re: [PATCH] tools/hotplug/Linux: don't needlessly use non-standard features in vif-bridge

[Jan Beulich <jbeulich@xxxxxxxx>]

On 01.09.2020 12:16, Paul Durrant wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 01 September 2020 11:11
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Paul Durrant 
>> <paul@xxxxxxx>
>> Subject: [PATCH] tools/hotplug/Linux: don't needlessly use non-standard 
>> features in vif-bridge
>>
>> We're not after any "fall-through" behavior here. Replace the constructs
>> with ones understood by all conforming shells, including older bash
>> (problem observed with 3.1.51(1)).
>>
>> Fixes: b51715f02bf9 ("tools/hotplug/Linux: remove code duplication in 
>> vif-bridge")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
> 
> If using fall-through is indeed a problem then vif-route will need a similar 
> modification I think.

Oh, indeed. I had meant to check before sending, but then forgot.

Jan