Re: [PATCH] golang/xenlight: Move to an entirely external repo

[Wei Liu <wl@xxxxxxx>]

On Fri, Sep 04, 2020 at 05:40:00PM +0100, George Dunlap wrote:
> Remove all go files and generation targets.
> 
> Add a convenience macro to build the package from staging.  This isn't
> really meant to be called directly; rather, it's meant to be called
> from a corresponding build target inside the external xenlight package
> repo.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> CC: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
>  tools/Makefile                       |    5 +-
>  tools/golang/xenlight/LICENSE        |  502 ----
>  tools/golang/xenlight/Makefile       |   36 +-
>  tools/golang/xenlight/README.md      |   28 -
>  tools/golang/xenlight/gengotypes.py  |  738 -----
>  tools/golang/xenlight/go.mod         |    3 -
>  tools/golang/xenlight/helpers.gen.go | 4182 --------------------------
>  tools/golang/xenlight/types.gen.go   | 1194 --------
>  tools/golang/xenlight/xenlight.go    | 1273 --------
>  9 files changed, 10 insertions(+), 7951 deletions(-)
>  delete mode 100644 tools/golang/xenlight/LICENSE
>  delete mode 100644 tools/golang/xenlight/README.md
>  delete mode 100644 tools/golang/xenlight/gengotypes.py
>  delete mode 100644 tools/golang/xenlight/go.mod
>  delete mode 100644 tools/golang/xenlight/helpers.gen.go
>  delete mode 100644 tools/golang/xenlight/types.gen.go
>  delete mode 100644 tools/golang/xenlight/xenlight.go
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 198b239edc..f24d7b6f74 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -31,7 +31,6 @@ endif
>  
>  SUBDIRS-y += xenpmd
>  SUBDIRS-y += libxl
> -SUBDIRS-$(CONFIG_GOLANG) += golang
>  SUBDIRS-y += xl
>  SUBDIRS-y += helpers
>  SUBDIRS-$(CONFIG_X86) += xenpaging
> @@ -113,7 +112,7 @@ endif
>  #    Pull to the most recent update (as if you had checked it out for the
>  #    first time)
>  #  subdir-all-${target}-dir
> -#    Do "make all" for ${target}, including all prerequisites (such as 
> +#    Do "make all" for ${target}, including all prerequisites (such as
>  #    configure)
>  #  subdir-install-${target}-dir
>  #    Do "make install" for $TARGET
> @@ -126,7 +125,7 @@ endif
>  #  ${target}-dir-remote
>  #    Where remote repositories are cloned
>  #  ${target}
> -#    Where a copy of the source files are put when building a source 
> +#    Where a copy of the source files are put when building a source

Unrelated changes here?

Wei.