[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Arm64: fix build with gcc 10
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 8 Sep 2020 14:17:08 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jUfWRU8Los/WBQ4eb5Br22TUW16+XVD0AD7wtu2sX+w=; b=K/aETcw7UI0QxhKx6Oe6ZQdkub22M6gTAzjXEbSnEEKolzejE1VWQZRVKEfOibPrBhBP4Fg/leto3jtfdALHj/zTxZMCzBIZYYn1LnE3NOpEzN6YpAqY/XYmBjL4kgQivg+AHAt95/x+nnwbDlPjuXsHGuHIBJ+4WVAxUJFcGf3FVqKT5s44poZSP2CzY2/uG5VVdjnIJHcap9wtaeNxsldQ5YV4jgIa7VBjYYi0shdITxyqjaDTz87BfVvWfeMVy66aF0QqyZTa1wXNhkPY5SDT5uW/EQrs9K5RK20HcOhJNXTWceBGo8O5ZoIZ0sk9rMGUbY9nStr8EQZaj0T5PA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ho+o8XomJfTZEAZ9SkPZ0u9WowYA5jvcZvGiaHJxLy6+quklydyugM885o1x0qhFbeDRpn3MW5QrVRUecEgZ5buYaHATC0w+MltO+idTPVhCgpDYoYohWsg0j7BBsmQpUyHSio26qssRLC3o7EB3eFGIzQuPbxRXWvhCriACH9gjZK/J5VFychnxFTiTo33SyiJpaxgjAF8ktX/9vOlGjgBZ0xaUb2pzTjDKUAUxB9hCb4OxXlJtEKcV1QvJ/ULqMj9hM6ehdkcVNkpR5wM3BSZ4MdRx1NHoFgULZ9u4lZdJSap8mdb5q0C5s/vzljl5Mk/e273Q0uF0FZIsPpo7lQ==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 08 Sep 2020 14:17:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWhd9Vq9iCRBnsnkuk6dw8UeDDDqletaaAgAARjoCAAAKFAA==
- Thread-topic: [PATCH] Arm64: fix build with gcc 10
> On 8 Sep 2020, at 15:08, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 08.09.2020 15:05, Bertrand Marquis wrote:
>>> On 8 Sep 2020, at 13:53, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> With gcc10 inlining is (no longer?) the default for certain atomics.
>>>
>>> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> --- a/xen/arch/arm/arch.mk
>>> +++ b/xen/arch/arm/arch.mk
>>> @@ -12,6 +12,7 @@ CFLAGS-$(CONFIG_ARM_32) += -mcpu=cortex-
>>>
>>> CFLAGS-$(CONFIG_ARM_64) += -mcpu=generic
>>> CFLAGS-$(CONFIG_ARM_64) += -mgeneral-regs-only # No fp registers etc
>>> +$(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno-outline-atomics)
>>
>> Why not adding this before with the other “call cc-option” ?
>
> I elected to group it with the other Arm64 specific ones.
ok
>
>> Also it might be a good idea to have a sentence in the commit message with
>> the
>> error happening when this is not added:
>> undefined reference to `__aarch64_ldadd4_acq_rel’
>>
>> Because some might need to backport this to other Xen releases if they
>> switch to
>> a new compiler (although i could not reproduce that with Xen 4.14).
>
> I guess I'll go with Julien's suggested description (with some
> minor adjustments perhaps).
Ok but please mention the error so that it appear somewhere :-)
Bertrand
>
> Jan
|
