[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 15 Sep 2020 13:02:33 +0200
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 15 Sep 2020 11:03:04 +0000
  • Ironport-sdr: se2nB1KNEgkA2saXlVTVciS5aFWI9gki3+Qfxz2OLBzQa2cRfbfbIsNIzgx0uW+j0wushMnicD ofvvOgYdy9rC1YTlS7F0t/LLJf5hFdPlvysjm20hgX/V/JlvTNOXB4yqI3fF1uWJc4/2z8yvrD iCMItLAZUeQAEy3qLATiw9Yq1QueR2PxQ6yXthFwBQySUc4WqHzCMsRbzz/B8FVJDZEWFxQQ/+ qEoJZSZzKFU+D7doHNWhv8RKTwj8nRwAhAH4pRbAzsHf6kAn/Bap4numJ28K+JRtOh41PxnKnE ugg=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Sep 14, 2020 at 02:39:33PM +0200, Jan Beulich wrote:
> This combination doesn't really make sense (and there likely are more).
> The alternative here would be some presumably intrusive #ifdef-ary to
> get this combination to actually build again.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm not sure I see a way to cater for Andrew requests while allowing
PV_SHIM_EXCLUSIVE to gate options in order to be able to remove
code.

Maybe PV_SHIM_EXCLUSIVE should be moved to the top level Kconfig
screen on x86 and behave like a list, so that you select a 'Normal'
hypervisor build or a 'PV shim exclusive' build, and that could
completely change the contents of the menus?

If that doesn't seem suitable I think the proposed patch is a good
option unless someone has a better approach.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.