[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 3/3] x86/shim: don't permit HVM and PV_SHIM_EXCLUSIVE at the same time
On 15.09.2020 13:02, Roger Pau Monné wrote: > On Mon, Sep 14, 2020 at 02:39:33PM +0200, Jan Beulich wrote: >> This combination doesn't really make sense (and there likely are more). >> The alternative here would be some presumably intrusive #ifdef-ary to >> get this combination to actually build again. >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > > I'm not sure I see a way to cater for Andrew requests while allowing > PV_SHIM_EXCLUSIVE to gate options in order to be able to remove > code. Yes, I'm specifically hoping for his input, in particular in light of the additional argument given in the cover letter (HVM not actually usable in this mode). > Maybe PV_SHIM_EXCLUSIVE should be moved to the top level Kconfig > screen on x86 and behave like a list, so that you select a 'Normal' > hypervisor build or a 'PV shim exclusive' build, and that could > completely change the contents of the menus? This might be another option, yes. Let's see what Andrew thinks. And btw - the patch needs an update anyway, as I've lost the defaulting to Y of this option. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |