Re: [PATCH 2/5] sched/arinc653: Rename scheduler private structs

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Thu, 2020-09-17 at 13:09 +0100, Andrew Cooper wrote:
> On 16/09/2020 19:18, Jeff Kubascik wrote:
> > diff --git a/xen/common/sched/arinc653.c
> > b/xen/common/sched/arinc653.c
> > index 7bb75ffe2b..d8a23730c3 100644
> > --- a/xen/common/sched/arinc653.c
> > +++ b/xen/common/sched/arinc653.c
> > @@ -50,38 +50,38 @@
> >   * Return a pointer to the ARINC 653-specific scheduler data
> > information
> >   * associated with the given UNIT
> >   */
> > -#define AUNIT(unit) ((arinc653_unit_t *)(unit)->priv)
> > +#define AUNIT(unit) ((struct a653sched_unit *)(unit)->priv)
> >  
> >  /*
> >   * Return the global scheduler private data given the scheduler
> > ops pointer
> >   */
> > -#define SCHED_PRIV(s) ((a653sched_priv_t *)((s)->sched_data))
> > +#define SCHED_PRIV(s) ((struct a653sched_private *)((s)-
> > >sched_data))
> 
> While you're cleaning things up, please delete these macros (possibly
> in
> this patch, as you touch every almost every user).  They strictly
> introduce type safety issues, and are in the process of being taken
> out
> of the other schedulers.
> 
Agreed. See, e.g.: a1c329c2828b ("xen: credit2: make accessor helpers
inline functions instead of macros")


Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part