[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] sched/arinc653: Rename scheduler private structs
- To: Dario Faggioli <dfaggioli@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Jeff Kubascik <jeff.kubascik@xxxxxxxxxxxxxxx>
- Date: Fri, 18 Sep 2020 11:52:51 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dornerworks.com; dmarc=pass action=none header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkFj+gQKkS8Wf+rzmpwOFzT2MJzmSgIYph7oG+SRnRI=; b=I5PI90vuaN4ejd5mQ25AVWXMjfl8ZIEVhVzJhXDtLEqWB2i+D7JgrlAfh8/+X+ivCzoxh6Ac+kQwy2Te+7pHOQN6zCYjh5itYuiHe8mXoczQO0siYGH4kh9CzUsK5kBTwygcLjkDQY6omlF+UTQdmHwZktDNiaJxO4Uy19e4gJ0gLpEr0r1X6DdiO0DXg+jLbgouDkpNZvrT7oDyokt1RbhqSm6TPmjdHn6Pauns+rTYrZ1mn8lLiKYMToJrixSsUUHWIZkm9qx86hgWvysZDcbUIsdCU81zm3cX5e63McfuwIGALLnqB2Mrj1I9BFZQvHEJdbplnumk2PGa5Zazog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=GvbTxY8wN13V2II/adpqghlbPEHp1ReZcT0pnjtARUGIuEM6n6IrdwoV94+rcaRJvLua2BJLeA0lNL0LhRyeRkjknQnxqBSutbUGl1nSOtB7kzt8G0jmSt13Y73x9A1ZbDWZ4F5GbXxbJB8p2Yccf0aI5qQWYBiD7JlFk9shlwBisnGlKl/AjVTuahMxO2sirNNorJQvMX+BlgXOjKvlHxGw9YYx1OMNJSQ51Bm41nFgoKxAJLBXErnHaEtrv1ZCpZX4SacpH0w/y2oN4EF2k1TY32Ac6vJqhsHGDNhdp9U6ywMiaByV51QAcT8OPiCHGmArXrlc1lcWqTG6V9Pv5w==
- Authentication-results: citrix.com; dkim=none (message not signed) header.d=none; citrix.com; dmarc=none action=none header.from=dornerworks.com;
- Cc: xen-devel@xxxxxxxxxxxxxxx, Josh Whitehead <josh.whitehead@xxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 18 Sep 2020 15:52:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
>On Thu, 2020-09-17 at 13:09 +0100, Andrew Cooper wrote:
>> On 16/09/2020 19:18, Jeff Kubascik wrote:
>>> diff --git a/xen/common/sched/arinc653.c
>>> b/xen/common/sched/arinc653.c
>>> index 7bb75ffe2b..d8a23730c3 100644
>>> --- a/xen/common/sched/arinc653.c
>>> +++ b/xen/common/sched/arinc653.c
>>> @@ -50,38 +50,38 @@
>>> * Return a pointer to the ARINC 653-specific scheduler data
>>> information
>>> * associated with the given UNIT
>>> */
>>> -#define AUNIT(unit) ((arinc653_unit_t *)(unit)->priv)
>>> +#define AUNIT(unit) ((struct a653sched_unit *)(unit)->priv)
>>>
>>> /*
>>> * Return the global scheduler private data given the scheduler
>>> ops pointer
>>> */
>>> -#define SCHED_PRIV(s) ((a653sched_priv_t *)((s)->sched_data))
>>> +#define SCHED_PRIV(s) ((struct a653sched_private *)((s)-
>>>> sched_data))
>>
>> While you're cleaning things up, please delete these macros (possibly
>> in
>> this patch, as you touch every almost every user). They strictly
>> introduce type safety issues, and are in the process of being taken
>> out
>> of the other schedulers.
>>
>Agreed. See, e.g.: a1c329c2828b ("xen: credit2: make accessor helpers
>inline functions instead of macros")
That should be easy enough - I'll make this change.
-Jeff
|
