Re: [PATCH] build: always use BASEDIR for xen sub-directory

[Bertrand Marquis <Bertrand.Marquis@xxxxxxx>]

> On 2 Oct 2020, at 14:17, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 02.10.2020 14:44, Bertrand Marquis wrote:
>> 
>> 
>>> On 2 Oct 2020, at 13:38, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> 
>>> On 02.10.2020 14:34, Bertrand Marquis wrote:
>>>>> On 2 Oct 2020, at 13:12, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>>> 
>>>>> On 02.10.2020 12:42, Bertrand Marquis wrote:
>>>>>> Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead.
>>>>>> 
>>>>>> This is removing the dependency to xen subdirectory preventing using a
>>>>>> wrong configuration file when xen subdirectory is duplicated for
>>>>>> compilation tests.
>>>>>> 
>>>>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>>>> 
>>>>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>> 
>>>> Thanks :-)
>>>> 
>>>>> 
>>>>> (but more for the slight tidying than the purpose you name)
>>>> 
>>>> Feel free to remove the justification from the commit message if
>>>> you think it is not usefull.
>>> 
>>> Oh, no, it's not like I consider it not useful. It shows how you
>>> arrived at making the change. It's just that I didn't consider
>>> making copies of xen/ something we mean to be supported. I wouldn't
>>> be surprised if it got broken again ...
>> 
>> basically i do this a “cp -rs” of xen subdirectory so that i can have 
>> directories
>> in which xen is compiled for x86, arm32 and arm64 and recompile all of them
>> quickly without having to go through distclean, config, make each time or 
>> modify
>> the original tree.
> 
> But then you must have adjustments also in the top level makefile,
> such that besides "make xen", "make xen-xyz" also works.

No there i am only compiling the hypervisor, not the tools, so only xen subdir.

Bertrand