[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/rpi4: implement watchdog-based reset

  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 9 Oct 2020 07:48:05 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSph6GES7caMfjI+9zAybban9hXyWMX1td9tdi8K7RM=; b=Dx7wbKDIlFYT6I/JovbHAZMSU7hnpT0P+pgbpEU8Q/TcaDvjbFTtvj/1Z+L9OS3qLC3U8VVIX9mVqAJIQdC7FNvRoVh14pM8F4RbjKKc31w7VFZN3GUKmk3ufjy886KKOX8xivE7mCY6cBslbVo/npBJNT38Fb5b1VopUrq6Rgd9QiStINzHxH99XuEgJPfaXMqawAnteJs9/TX7TvDRnWOi43vwSNo6ooedPVzHY/Z+4IAbq72vgKeWxI9DNytSByYef7lojxj0X0NHI++gUOBJl7NVUweCdF8qJZfGQBzq788VVvyfWZLXnmEtGMZsyO20oJEI+WvEgDvBD8gn5A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYZU/DsjQNWu/ZGeGmmrHXc7EGat12RP3zIpEU3yp9yjF/8D5/6EEKvO13EhpL5NDdQVzVtK+1d70nbG8zRU+NabOUGCGVjRysGlvINdTo9eWv0EIuSMhr+pglS0fNB1W4bN1ntK7toGrN5akv3j3OfQI/x1wicYbMkR/9R9U7p5vCIl4d5ok882050TgcxtS5882OLEC7/Ew+acc7xXucZVJlNYvJ9/A6f3x2Io3QkDadl/tE5XANHbsGMR5eJZsPkJleIIIhlNc6gB1hyJxw4IM2ujFlAk283GT1GkQY03tquoIwQb3WXNJbpgkKAkCdiJMDto3boB+FJKbei2RA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, "roman@xxxxxxxxxx" <roman@xxxxxxxxxx>
  • Delivery-date: Fri, 09 Oct 2020 07:48:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWnPqc7v70BAMN4EaAQA/1huLhsamNV4yAgACv0gCAAN+3gA==
  • Thread-topic: [PATCH v3] xen/rpi4: implement watchdog-based reset

> On 8 Oct 2020, at 19:27, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> On Thu, 8 Oct 2020, Bertrand Marquis wrote:
>>> On 7 Oct 2020, at 23:38, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>>> The preferred method to reboot RPi4 is PSCI. If it is not available,
>>> touching the watchdog is required to be able to reboot the board.
>>> The implementation is based on
>>> drivers/watchdog/bcm2835_wdt.c:__bcm2835_restart in Linux v5.9-rc7.
>>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>>> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> Maybe a printk if reset was not successful ?
> That not quite platform specific but we could add a printk to
> xen/arch/arm/shutdown.c:machine_restart if we are still alive after
> 100ms.

Even nicer :-)
Definitely usefull to see something if for one reason reset/restart did
not succeed for whatever reason.

> I'll commit this patch as is and maybe send another one for
> machine_restart.

Please tell me if you want me to handle that one (at the end I did request
that so not really fare to ask you to do it:-) ).




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.