Re: [PATCH] SVM: avoid VMSAVE in ctxt-switch-to

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/10/2020 14:40, Jan Beulich wrote:
> Of the state saved by the insn and reloaded by the corresponding VMLOAD
> - TR, syscall, and sysenter state are invariant while having Xen's state
>   loaded,
> - FS, GS, and LDTR are not used by Xen and get suitably set in PV
>   context switch code.

I think it would be helpful to state that Xen's state is suitably cached
in _svm_cpu_up(), as this does now introduce an ordering dependency
during boot.

Is it possibly worth putting an assert checking the TR selector?  That
ought to be good enough to catch stray init reordering problems.

> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>