[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 0/3] tools: avoid creating symbolic links during make
Juergen Gross writes ("[PATCH 0/3] tools: avoid creating symbolic links during make"): > The rework of the Xen library build introduced creating some additional > symbolic links during the build process. > > This series is undoing that by moving all official Xen library headers > to tools/include and by using include paths and the vpath directive > when access to some private headers of another directory is needed. I'm OK with these changes and inclined to give my ack and commit all three. I did have one observation: it is rather odd that all the autogenerated header files are each generated by the relevant tools/libs/foo/Makefile, but the file is in tools/include/. This is particularly odd given that tools/include/ has a Makefile of its own which mostly does install stuff. Can we at least have a comment in tools/include/Makefile saying that it is forbidden to add rules which build include files here, and suggesting to the reader which other Makefiles to read ? Thanks, Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |