[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inconsistent pfn type checking in process_page_data

  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 28 Oct 2020 10:39:55 +0000
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 28 Oct 2020 10:40:17 +0000
  • Ironport-sdr: 8cLQOr5nG8EnxRvOuk4DZmmF4pWFM/NakMMBdp+BV+P3auRfNvcUPkhNV4CKMCZTDwobVm/+Kn GIph360J0IwdDBHxW7RKjXnpDek+1tqsJ3bqbuW/4wcX0FVqMFolXYSDerGyAIQx88o+8GyfTx gQq79w4I95jTJQr2v+bLHvVdyuLztoJKxhcMWz5+0gA6w9ooisG9Exvb5afU4nmHTzE/nd/cgv gHWm4ByTxDOPfdYxAhjlh64NJjWmbHZ1vYdd3lZh+yqf6QmBwvFRFLFD1YfQ7M3aOEXElp74LP tWQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28/10/2020 10:28, Olaf Hering wrote:
> Am Tue, 27 Oct 2020 23:18:47 +0000
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>> I suspect we probably want an is_known_page_type() predicate on the
>> source side to sanity check data from Xen, and on the destination side
>> in handle_page_data() to sanity check data in the stream, and we
>> probably want a page_type_has_data() predicate to use in
>> write_batch()/process_page_data() to ensure that the handling is consistent.
> From what I have seen, two (or three) helpers for sender and receiver will be 
> needed:
> is_known_page_type()
> is_data_page_type()
> maybe is_ptbl_page_type() for normalise/localise.

Ah yes.  That too.

I would however recommend against the name is_data_page_type() because
then the predicate is ambiguous with "== NOTAB".

page_type_has_stream_data()?  Its a bit of a mouthful, but the purpose
is very clear.


Attachment: signature.asc
Description: OpenPGP digital signature



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.