[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 28 Oct 2020 10:41:57 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hs7F69O9QoS00esJRc3gJv0VF6Rg8v0f/788uBjM3OY=; b=MHIa2mHRkXWPfJQWeN1yMkQ/rSQmWDYsYmnCFpVpZBYoxf8w43tJ+z7zvUXrsTP7cd2hwUT6B4vHBQFxQV+HdKVsFl1fnKpHjPWYuDGf1qJvE2iMq7A0xlfjwMAluOp++gYp8oi2m92HAY7rQfLI9CEpyQduz5WZgZNtbM6gCmCuuLlNN6onanINofYnUCJd72Hlf9EU7gsH17SCW1qfiW+lmEBQvMLQmc/HhTTfqnQ7nEz65wMKj9NcEj/LyyvSROVov+ZhOpitObvTaULZ8MmD2jXVPbpfR1hSroIvEmeL7/evBtiqW2plCpZcocxwCDBrD60uJhdZutogvUBz5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDqCdut410/4+XCKQmLaX/NdR7ggr7+/6nyR6JhIOPOESOUt+ixy4a6A3kPQe5F7nSaaLB0fV0YVi5qpVVoSanwgxDsUYeL1VDxSzkzZ7jwqkW7UAqYiyg5Gu4j8AepucgdHOx3l7Op+YB0l5szWDlLEyCYVmRqcGXDCJhDIrXV0ZNjQQu62iUmo3GB7haYm2c8s7GUFsdasbIsdc+wZiIWRXMnOeqksQ7Iz+TR3Fpk8hLK3v0gQ1zA7Ufdj1Ula5sE4z0Iq7YdG+yi+QF0ofXNDS4xKpTTIbLYB6U7Jt3WGGr6ARPTlqIEWT6cdiA9Ih8LnbPgnbl7F0+3Q8t2lCg==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 28 Oct 2020 10:43:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWq7waQtOOhLtUwkWCA6LhLv3lTamsG2AAgACCJwCAADjrgA==
- Thread-topic: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.
Hello Jan,
> On 28 Oct 2020, at 7:18 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 28.10.2020 00:32, Stefano Stabellini wrote:
>> On Mon, 26 Oct 2020, Rahul Singh wrote:
>>> --- a/xen/drivers/char/Kconfig
>>> +++ b/xen/drivers/char/Kconfig
>>> @@ -4,6 +4,13 @@ config HAS_NS16550
>>> help
>>> This selects the 16550-series UART support. For most systems, say Y.
>>>
>>> +config HAS_NS16550_PCI
>>> + bool "NS16550 UART PCI support" if X86
>>> + default y
>>> + depends on X86 && HAS_NS16550 && HAS_PCI
>>> + help
>>> + This selects the 16550-series UART PCI support. For most systems, say
>>> Y.
>>
>> I think that this should be a silent option:
>> if HAS_NS16550 && HAS_PCI && X86 -> automatically enable
>> otherwise -> automatically disable
>>
>> No need to show it to the user.
>
> I agree in principle, but I don't see why an X86 dependency gets
> added here. HAS_PCI really should be all that's needed.
>
Yes you are right . I will remove the X86 and make HAS_NS16550_PCI depend on
"HAS_NS16550 && HAS_PCI"
> Jan
Regards,
Rahul
|
