[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.


  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Wed, 28 Oct 2020 15:47:03 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=py2ONcKrlKEu5txZ1tzonQ1wYAZkRDAFdKmbS88XHA8=; b=RMFAik49+zP6mZqeNSGH7vNH0BZ+rIhzcs/1NkVxlmTAGpDSiQ/vPyo4Isz6yRcyVbXtYEh0dyC4Cg6I5qkI01AxqJt4jp3SibuWUiV65dlmXppR6j3gxA12J/Q6I4UMcTr9FXG2rix1E0QzRqCCCYQP6sMtRdrQRwHm306nDHGaWIgPxZO7LIvYC0GMQCAXy3hiHPfHgaohhxQV4jrrCZMCo3OU3Y1R52vqtgQ48E8ny6EjldkzyhQe6vIVem96QoYXxlY24PvCOHrFhOVOHjUhRz8k1DilDFh1WU5vFJhBaGWSTsSmw4lowV5i0ivfX9hz3ewnCMRonjairx/Tow==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RY0eEEHRGL3ma0HcjlUy3nDjUnjjnv7sVjgfcOUagKR7P1t5aGCEicQESw2u1dXsOtRYEF1BB/BgfHpsh5JgrfJJcP/kFpH4s3AzemdDAkc5wOQ471TTHL/PcvFuhKCBKuPl92z/K5O8Xt0cPiF6fFLFUtwlogy8oQeyp1FmsJOl0E+YnOWlRl9JJR7X2RrbRuXFo1ygssO62wlnwaBo45InSNWHl+bhSWg6z9ZfI4PXgK6JkFCz4JAqhpj5wPdHTyItz0PmleSVDORV71hfQd2sFSqFzNCKPVkfVN3reBRbW3JBgIXkj/34UD8g8StNtnRMCsNnFuKyYVwAm/8gjQ==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 28 Oct 2020 15:47:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWq7waQtOOhLtUwkWCA6LhLv3lTamsG2AAgACCJwCAADjrgIAADiIAgABHGoA=
  • Thread-topic: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

Hello Julen,

> On 28 Oct 2020, at 11:32 am, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> On 28/10/2020 10:41, Rahul Singh wrote:
>>> On 28 Oct 2020, at 7:18 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> 
>>> On 28.10.2020 00:32, Stefano Stabellini wrote:
>>>> On Mon, 26 Oct 2020, Rahul Singh wrote:
>>>>> --- a/xen/drivers/char/Kconfig
>>>>> +++ b/xen/drivers/char/Kconfig
>>>>> @@ -4,6 +4,13 @@ config HAS_NS16550
>>>>>   help
>>>>>     This selects the 16550-series UART support. For most systems, say Y.
>>>>> 
>>>>> +config HAS_NS16550_PCI
>>>>> + bool "NS16550 UART PCI support" if X86
>>>>> + default y
>>>>> + depends on X86 && HAS_NS16550 && HAS_PCI
>>>>> + help
>>>>> +   This selects the 16550-series UART PCI support. For most systems, say 
>>>>> Y.
>>>> 
>>>> I think that this should be a silent option:
>>>> if HAS_NS16550 && HAS_PCI && X86 -> automatically enable
>>>> otherwise -> automatically disable
>>>> 
>>>> No need to show it to the user.
>>> 
>>> I agree in principle, but I don't see why an X86 dependency gets
>>> added here. HAS_PCI really should be all that's needed.
>>> 
>> Yes you are right . I will remove the X86 and make HAS_NS16550_PCI depend on 
>> "HAS_NS16550 && HAS_PCI"
> 
> There are quite a bit of work to make the PCI part of the implementation 
> build on Arm because the code refer to x86 functions.
> 
> While in theory, an NS16550 PCI card could be used on Arm, there is only a 
> slim chance for an actual users. So I am not convinced the effort is worth it 
> here.
> 
> Cheers,

Ok. I will enable by default HAS_NS16550_PCI on X86 only. Once we have proper 
support for NS16550 PCI on ARM we can enable it at that time.
I will modify as follows:

config HAS_NS16550_PCI                                                          
    bool                                                                        
    default y                                                                   
    depends on X86 && HAS_NS16550 && HAS_PCI                                    
    help                                                                        
      This selects the 16550-series UART PCI support. For most systems, say Y.


> 
> -- 
> Julien Grall

Thanks,
Rahul




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.