[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/hvm: process softirq while saving/loading entries


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Thu, 29 Oct 2020 16:20:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k/DG2aYNv+hxwx2bL0bpNn0FsUDBwHEnHdbgGz6/Gy4=; b=N/TyU+y7pW7l4XQFJSbMS+NeOs3l32HlP5pPFSnnnZi6t9UKDlsMVL5OkJ/GuSWff2mC76KmjTV1Xuu7YyeLG35aUXSfzdMxGKwzJL/jx21tkSKPNB6O39yyZQQK9xRk0+O1wwVDah/9qLzv7bCRhoMvwvRGYYWGcSezGqCJ0Dh/rfNkm5oumbSyrYZOLsSt8iKkHtoXrNoX9uaNpcFsx29yw3HVfLv0QBnq6xFIIqfvavbI4q4KP2vsePBlS2XbjqMlaOIRMPFu6dmz97sjRure3GoHfdVj1ffGMtQe8MH+mtVN+yZxEeeH3dzGKn39PiQBkZJzdUOHG1LtXt/oyw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EojKTFJ3CNlSn4NWzvvQ+gnJF8cHi+O8Xvnfh4wSa2XPv4x9Ei4fZ1Zuwrt1R88VCRa2GqzJRtMbzfizgLlqO4clusj6bQeLtZF5MSs3BBj0PN65jH9iyX8iHJtYDydKbAHBKbyFxG646fS2UxxaV2fyyUIMLGDnBJ33gHQXOWdUlGrSySr05xguEW1wvTqlTayYxYs3sR5V8fOMK1mZ7c9FBWiWLQjEvxwgILZlD49dQWt7UjZvmp/BSd0ijHRtujxHHu9GJ0N+ynbeK9nx1zUF9nVXTKKNmXBGPJJKRGANMupCBXV0dxZ+17TNDqlDS+WgWQ/jAVwe+IjFG5g7nQ==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 29 Oct 2020 15:21:25 +0000
  • Ironport-sdr: ZbmUzLXINQEI188lCzrT/6a0tiCE64K9cvEcdtWAah3G9RGMttHzMYz1oCzmW6/DakExeL/aCi VX9wJ/tElUhaV6wwsvdUIPrGMlrz7S23dWcSp2lK8baWj8Img/2bSL8sOvuxF1gw5NQfO20ySI tZJLR0HXy0/JGSiQ4piM+Grl1YCgG3R+tbYGNUrMnin/g86TBq3CHmEeBccCnVvf+rBYeKw4hQ C8LnvgaeJBGXgJ3eST2P0aiDxcgY4aecHbvoNIUph0h7DQkR9/0hweOuTr2hpAdeJ9Y7f+r5Sw 53Q=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On slow systems with sync_console saving or loading the context of big
guests can cause the watchdog to trigger. Fix this by adding a couple
of process_pending_softirqs.

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/arch/x86/hvm/save.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c
index a2c56fbc1e..584620985b 100644
--- a/xen/arch/x86/hvm/save.c
+++ b/xen/arch/x86/hvm/save.c
@@ -21,6 +21,7 @@
  */
 
 #include <xen/guest_access.h>
+#include <xen/softirq.h>
 #include <xen/version.h>
 
 #include <asm/hvm/support.h>
@@ -255,6 +256,7 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
                            v, i);
                     return -ENODATA;
                 }
+                process_pending_softirqs();
             }
         }
         else
@@ -268,6 +270,7 @@ int hvm_save(struct domain *d, hvm_domain_context_t *h)
                        d->domain_id, i);
                 return -ENODATA;
             }
+            process_pending_softirqs();
         }
     }
 
@@ -341,6 +344,7 @@ int hvm_load(struct domain *d, hvm_domain_context_t *h)
                    d->domain_id, desc->typecode, desc->instance);
             return -1;
         }
+        process_pending_softirqs();
     }
 
     /* Not reached */
-- 
2.29.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.