[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/libs: fix uninstall rule for header files
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 29 Oct 2020 15:24:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qa/pCWZFXD+sFV8cZRKbKmtTkBEMrqltU9AtHXXs1fs=; b=Av0QU7imBh8AfIvhHSjL74wYHswb4rDZs6Brfa7ERzNlNGuKP8gJP5s8VuwYu7EkA6NhxseX2yuKkm1qG0LVuY38PcK88JkclZKcvA6di9ca3cw2b4BV24ZCTNiUD3Mv53AY8NoBDwXslqTq83XruGUrYMdVjJ2PGuAKbw/Ol274/NVT/P9Y2w+m1PSgQ/pHz0FbwSWmvS8PV9698QZlopx946iUbTWVWzLl6xTwBWSmpx6hOb9Dm8sIi6FHt6awO5jZwiGP30XQMVusQAX8t71JzOEG5GDHS2imEPctTURAE11gV+AjYK+5nWe+S6Kt4wWDTjhjr/m2zvreo143xg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOMGVFiPMiaBeVPts20aQ9oPgSIDgg5LOJtJFMbBNBeoshi5RvycfpphHMkmgw4ip6sj/2MN4C1TnYQiMt3jJKOZMzkT1GqOqlBo8E8dZ/oVetlgqb0c8VTw4mF+cfz9cw1m4UZIv0/kguHI1hemmHUXKD0tjCM3578/f/sVm9XLLtg66iIrn90vZUO6jKYgwJoupJ80fMKX/IOR1cedatOzJLPF1M/0WEch9T3ZWyMlUOXlsLxiFJNPKnpN2BqxFU8ouMs1K2eiaxVX8ImzDAhN3WoJDlBXsKIwrWf/Re6b3+SjN6cNO/24NU8Hsem97YKntZN9tIjPTHwncW5YBA==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 29 Oct 2020 15:24:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWpeifIAHoNnN0LEeTc6ujCHuJAqmuw0aA
- Thread-topic: [PATCH 2/2] tools/libs: fix uninstall rule for header files
> On 19 Oct 2020, at 08:21, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> This again was working right only as long as $(LIBHEADER) consisted of
> just one entry.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
The change is obviously fixing a bug :-) and the double $ is required to
protect from make.
Cheers
Bertrand
> ---
> An alternative would be to use $(addprefix ) without any shell loop.
>
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -107,7 +107,7 @@ install: build
> .PHONY: uninstall
> uninstall:
> rm -f $(DESTDIR)$(PKG_INSTALLDIR)/$(LIB_FILE_NAME).pc
> - for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$(LIBHEADER);
> done
> + for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$$i; done
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so.$(MAJOR)
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
>
>
|
