[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header

On 29/10/20 17:56, Arvind Sankar wrote:
>> For those two just add:
>>      struct apic *apic = x86_system_apic;
>> before all the assignments.
>> Less churn and much better code.
> Why would it be better code?

I think he means the compiler produces better code, because it won't
read the global variable repeatedly.  Not sure if that's true,(*) but I
think I do prefer that version if Arnd wants to do that tweak.


(*) if it is, it might also be due to Linux using -fno-strict-aliasing



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.