[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/decompress: make helper symbols static

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 18 Jan 2021 16:12:16 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzEh/jMPhSyNWH7VutvjF2OzCvFhsLL8ozxHGx760Z0=; b=QvE/6OCGXxRGOLdaX6zrTV3RtCw7tb3OA0Zv3MW7pHgI4EYWhc2VGtN7SEMHi+H2mqbbhaLK63bJ2nqZ9RMoCWap0AoOAmOxqnwQSC2GaxvV+I7LKLquLaubGbkmduHLM/+wkwvl3lLEi1GcjZERFM1iXuil6Me53FtbCMDyX45ZiVHRJhz5chDsy1FMjl2dmnyXZW6ZdDkSK9+OZ4P7vHd03le4LtszOkpRNwfaZus09p5MMd4WhffeMD0xusRiK3I4bYUijRC1FpkHXRyg88rGJCHflHuh9gfkvtpbTylAS//4vsNpmBp0iqnQoC65lP+DasBRF6qbRVaqd27awg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqQBMMkN86LTIoplttZe8rSrYLUfuV6PSqQSk1B+pTC0obzQpq0Z0SQURMludoic+1M0P18y8wWzxoHMOy8uM3srhugU11SGN9+Wn2G8oWek6iOId2Pq9VvsqSMLuX3Z2AVKZ2n+aPSaof+8lAsHjeMf4xjR4AU7qDmNfp9wMKvjhzpeXqldG8TfyIx/KRUd380Ko0WZ14G7yR82npNTlp9VnR0rKj8d3WRu54RJR7TeQbcTbqtcmdNugsbhYg9SlFv6I8ELfcTgB4uc7AScCUvCtp0nQnixNOdFHROJGNeE1gCilm1jY42EVRIxMWGoo5rDFkz2v6oAmxTTQBi0Sg==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 18 Jan 2021 16:12:43 +0000
  • Ironport-sdr: AqzW31EKOmRmDgwM7gGSCGgz2B8j7V0rffNkhNPy75jzOC7NkNgGecPAWum+l+Q9NhFi1Gdhgh 8p+lhRIVIMZARpSMiQsDlYUAidur74e9gAMoavNnznn/yqp57gjFGy58BLhwyaJKUKyJsyKC77 OQDVxai2D3ud54sK7eeUKVfBK0e3rnercYdIVBw+mshW07M6rqswGPGh8ANPBGW9uezwENF6ey eSmxxU8+j5KLS/WbSq8ksFRhk8DgLeozK1lqsyzCL1/HXz1psIXBH9nBcbtXxYYzUXXJci5etU 0OQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18/01/2021 16:09, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] xen/decompress: make helper symbols static"):
>> The individual decompression CUs need to only surface their top level
>> functions to other code. Arrange for everything else to be static, to
>> make sure no undue uses of that code exist or will appear without
>> explicitly noticing. (In some cases this also results in code size
>> reduction, but since this is all init-only code this probably doesn't
>> matter very much.)
>> In the LZO case also take the opportunity and convert u8 where lines
>> get touched anyway.
> AFAICT, this patch
> * was first posted after the last posting date for Xen 4.15.
> * is not a bugfix.
> In which case it has missed 4.15.
> Please correct me if you think I am wrong.

It's part of unbreaking Linux kernel compressed with zstd, which I put
on the 4.15 tracking list.

Without the work built on top of this, you can't boot Fedora guests. 
The dom0 work is committed into staging today.  The domU work is in




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.