[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libs/evtchn: fix build on NetBSD.


  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 18 Jan 2021 19:01:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90NQWrmSkoJXHsEpu6BC/fUezLZXN/qCHQ/MXV9EXbg=; b=Jzc2rQNmg8EaaDwt+zTv6L3CUfTVKBFyC4VKcGu45eoCZSFKVYvZaZJ9OeeZXQVEP5KvR9fIqB9Dc0uNLR4M2fgCVNwPbgKRkNSn5vHe4AVdBQwFPq24UckW/hoElcEp358Q59t2zbr1PI1JBQtmO6ULn7yvTGhv71n9decNeIyElZM9DjDZBULm4JY1ICJ2bW04W6nhjHbydQ0z9pUFcDBiBoholOayBgQ4kLgtz1GfF3lFopkL23Di5NWqM6oZWI4F0vXZj7zPfHPoJVEakVE4gquwhxCVv4carDt1c2YfkJh1PhNcvtuSN0ij5rQ5DJMT9Ko96QJ3TCLNt1pAqw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbD78T41tllQKTwcGAOVNH+zAUF/H5Yh8C+M16sVYepNqPDiyYcDxaFHZj6pIOL3xci1Udf15smd4lOGHfXDuHJdWJRUj39yr6JWhBuFTtQpg1q74ciIULA+1FT8oHYc6xzSpGO4m7yW1V92ZfHC8Ty8YvAv+FnGok0fFMo4zM6GYAtN/QD2iS3gO5BlBQ1Kg2sN9jJKV76p4iiGkiiXpTBuLHn4TL2zKWym5ZRYylSyYKzn8NGHAkFeMe5XZPpM0b4DZLWXovKYZ2AMrafWQ6dWGhkb8RBhrzDQekkkrEUwkS3QUD5iwFY4Yu7IoZ/QpHzR5GppQPsF+jN8cEisFw==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 18 Jan 2021 18:01:57 +0000
  • Ironport-sdr: h9pqkL1sGDyOYJ/LFSYxOHUzDzXo++NEJw7z6DLbCieQnvJ+NPCX/pxIJrM4n12ceyJ08SvRHm DlFg71f2TUI6QlKl/pFh8DZZMpOT/lwDVg/q3twxI1FeRaO3EKnWI4M3zeSK+Yo1NHcvgad5TY Ih/0YHFsEIMOqLWu2OLtmcveFC3FHFpGE1FNUvbu4K7VikkKlDWoJdozoDcajBMPe3en41iJ1a 9vURaGiS85ZrFnW2ZGN8OMwb/3n4+S5klaq+8J6BgaC5jZG5E/nbSnKUvUtsfFufJPQl6pXXlt pDs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 12, 2021 at 07:12:30PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@xxxxxxxxxx>
> 
> use xenio3.h for ioctl definitions
> read_exact/write_exact seems to not be available here, which cause
> a gcc error.
> Use plain read/write, the xenevtchn interface won't do partial read/write
> on NetBSD anyway so it should be safe.

I would add: This is inline with the rest of the OS specific helpers
that also use plain read/write calls.

> 
> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.