[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/domain: Introduce vcpu_teardown()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 19 Jan 2021 09:42:24 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/F2mlz5qFbwo/bUppGNnDTcJLEGO5d1XGku7syRmjk=; b=Oo5gy8EqEkiTK9TO9zzDgV1S7At3uxvkmtVPofyEGZQhbPssVkQqS42Ei5cFvlrk70YaVcSzQ17ssj4LKm2M3gsg+1dlJqdXbLD807lbRdFwmAOb/E7khydX0BhMpWVvHKgA68lypQuVnCraxe8nFOWaBHC1f3GS2hpt2sWebWMSQRgkl5h3P2xQxvqJTa4l5GQlDWPas0jT0HaiOceYaKSRUUmOvuXXYfAi9FjHLrSS2SPRXL3Av1IuULDGuXLUAxQ7aFYedFsGmKNLTaGjaBtsSS1oDuTdu4olOJn5VVzzCflOtRRFmyL8+iHHe9t2LMhQhY68vPZ/Vyn4SJYiwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/PaD4Q0gvPpiiWFSI91YfJR2VCsPiDb9YjrNRrGGSvTt4NjV/Mz8kBBrXhu4pvpSostz2ryS/FlLh45q79OlTrZ6u5KFWC10cEsgEesVIK2R3ohz6xo2JwZe2eqKsCVnO0hpMHK9N57MP19RfD26DJNGSpZVcPE0jXXhmyqQXl4n33tXjEDEUIg/Yhr7xq+MDn2fppFZWHsKTlSZZfl5vsNvcyWGcKGma7wf7G4HRL1z4xpAbj+Uvfl3S/dO+kwqOf/s+y5FZFnZm9XjGHwFVBHBFKvKD4yf/shcdzclk9HlSlPEGsaGYPosMdkGhtBf0pf7W1t4XBx7f/PhIzIUQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Jan 2021 09:42:37 +0000
- Ironport-sdr: dc85SSn6/FyTf/g1sOYR4xwvuk7gdWDa2QICxAC2a/ybbFI0FXtPmULvwXoROgwJURipULLRr2 tZjKdhC1ddZezKpwDFpter+shDZRU+Zv6MnqqZvwOJXPW51Ql8N3U/jtS+5bikcnNEUuw5yoX6 79/Jc0PkwBwFEICjWFsBW/hIa1Ip1sUXqEX5r2ZxbqCWJbghXYv3XxSf+pgNT54QIAEdBLTp3X shbc13wY52qnb79K8VfWVIGAnuKjOoqUrbdmPQ7unN/qTjpUxTfa7NTtJ5XJy1QUZG4dwqijbV gYo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/01/2021 09:14, Jan Beulich wrote:
> On 19.01.2021 01:32, Andrew Cooper wrote:
>> Similarly to c/s 98d4d6d8a6 "xen/domain: Introduce domain_teardown()",
>> introduce a common mechanism for restartable per-vcpu teardown logic.
>>
>> Extend the PROGRESS() mechanism to support saving and restoring the vcpu loop
>> variable across hypercalls.
>>
>> This will eventually supersede domain_reliquish_resources(), and reduce the
>> quantity of redundant logic performed.
>>
>> No functional change (yet).
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
> albeit perhaps with a name or type change:
>
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -532,6 +532,7 @@ struct domain
>> */
>> struct {
>> unsigned int val;
>> + struct vcpu *ptr;
>> } teardown;
> I think the field either wants to be generic (and then of type void *)
> or specific (and then be named "vcpu"). Which one is better certainly
> depends on possibly anticipated future usage.
I think I'll rename to vcpu for now. I don't anticipate this being
usable for anything else safely.
~Andrew
|
