[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/2] xen: EXPERT clean-up and introduce UNSUPPORTED

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 26 Jan 2021 11:17:35 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+KAi+zGfpbgeFaHfnmZpWrNp5C+JaDdPMeXy06yDU4=; b=nxcPUfd/2vKbWeniK216nG23yttwq/hsGP58XlA/EtXGaB3x7BSpC8yimKrVVd9CiT48smTTvgaH+mQsvksWuG0h5NuKPmyjm5CF0lnoBX370wKVLzKPmW8gGxM2QGCIBWRk4bcfDk2GmCMfdgDvYKkIpeIjr/w20U32uGVQMStS/j91QxOAxu6NHrObpIxZlgXiUO0zl5P/WRCi/xBxwKYlvIUOaamot+ZVSJn+Hpiz7oyThrmYA0YuXT+REU3ONbLHdvnwR+5maawrTHfiEnySLdc7nFXySCFisIn7REXFDhBMTK/Ww5rH5gfGE0PWBIN1axaDZAvOGQoapVyriQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cc0DNY0D5usa90l1jSaTvGr2cvnJCiJDVgtMH3lzHAmHqRHfFnfhSloNdbLszQy2u1r89umjwF6zNhoYsc74uHI3cVaZFGhkX0lNL9Qeo8AGVQn6R3oFczFsaNkaqos0usWBrtLBTURlzSBYBe4Yrm28QYv/jyKQvYu0IzZN2By4tM/2HsvO5lgL4dW65caGOKdP0wT0EruWALscKauf8ks/EDo5/Fw+SkMVPJ5x6uTBgN7XSQQCFwNEO5GSHkIOGEPnMJ9/yKzLLim0YLTxEihwsuvTR+mTeGWMQaOruwUF1D7Mr7N47rOt2rGvq/Q+sagP7woEyI2n/3EM6jYvaA==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 26 Jan 2021 11:17:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHW82EN9R2ynrmbqk6EAVX0Oyalkao5otWAgAAc8QCAAAFygIAAAbYA
  • Thread-topic: [PATCH v4 1/2] xen: EXPERT clean-up and introduce UNSUPPORTED

> On 26 Jan 2021, at 11:11, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> On 26.01.2021 12:06, Bertrand Marquis wrote:
>>> On 26 Jan 2021, at 09:22, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 25.01.2021 22:27, Stefano Stabellini wrote:
>>>> @@ -77,7 +77,7 @@ config SBSA_VUART_CONSOLE
>>>>      SBSA Generic UART implements a subset of ARM PL011 UART.
>>>> config ARM_SSBD
>>>> -  bool "Speculative Store Bypass Disable" if EXPERT
>>>> +  bool "Speculative Store Bypass Disable (UNSUPPORTED)" if UNSUPPORTED
>>>>    depends on HAS_ALTERNATIVE
>>>>    default y
>>>>    help
>>>> @@ -87,7 +87,7 @@ config ARM_SSBD
>>>>      If unsure, say Y.
>>>> -  bool "Harden the branch predictor against aliasing attacks" if EXPERT
>>>> +  bool "Harden the branch predictor against aliasing attacks 
>>>>    default y
>>>>    help
>>>>      Speculation attacks against some high-performance processors rely on
>>> Both of these default to y and have their _prompt_
>>> conditional upon EXPERT. Which means only an expert can turn them
>>> _off_. Which doesn't make it look like these are unsupported? Or
>>> if anything, turning them off is unsupported?
>> ...You could see that as EXPERT/UNSUPPORTED options can only be
>> “modified” from their default value if EXPERT/UNSUPPORTED is activated.
> But this is nothing you can recognize when configuring Xen
> (i.e. seeing just these prompts).

Maybe something we could explain more clearly in the UNSUPPORTED/EXPERT
config parameters instead ?
We could also make that more clear in the help of such parameters directly.

I do not see how we could make that more clear directly in the prompt (as
making it too long is not a good solution).

>> If this is a problem we could also change those options to be default
>> to _off_ by renaming them to config DISABLE_xxxx
> Yes, this would be a possibility, albeit not necessarily
> one I would like.

This is not one I would like either.


> Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.