[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/15] zstd decompression for DomU-s + fallout / consolidation

Jan Beulich writes ("[PATCH v3 00/15] zstd decompression for DomU-s + fallout / 
> Only patches 1 and 2 are strictly intended for 4.15, paralleling
> the recent Dom0 side work (and re-using many of the files
> introduced there, for the stubdom build), but ones up to at least
> patch 6 may still want considering (and 4 already has a release
> ack).


> 01: libxenguest: add get_unaligned_le32()
> 02: libxenguest: support zstd compressed kernels

So these two are fine.

> 03: xen/decompress: make helper symbols static
> 04: libxenguest: "standardize" LZO kernel decompression code
> 05: libxenguest: drop redundant decompression declarations
> 06: libxenguest: simplify kernel decompression

I approve of cleanups of course.  But:

Which of these cleanups were posted before the LPD ?  I'm not
currently aware of any reason for a freeze exception here, so I think
those patches which didn't meet the LPD should wait.  Ones which *did*
meet the LPD should be considered on their merits.

If you could direct me to which those are I would be happy to review

> 07: gunzip: drop INIT{,DATA} and STATIC

I release-nacked this because I saw you posted it with this Subject
  Subject: [PATCH v3 01/15] gunzip: drop INIT{,DATA} and STATIC
which made me think you were targeting it for 4.15.  If not then fine.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.