[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libs/light: pass some infos to qemu


  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 27 Jan 2021 10:06:43 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfZPZPc8rhMC9aLWZU/Fyg5CKFAF2OI06+iPY8s20yM=; b=dDBb/EAs6SyrSV1qC03CV69xdDzDjDrAqGTW0qjexwkLrDyVxGj33XCEwDm9WTwi+7OZkpOMG1HEyoJo5RoaTKn7CpUGDy2+KmggLFwGSxcLETASwPogP6OqvyjHjYhsncEhuqVjMb+wQIQm9HGkMU+TULD8khvY2RG3ASSnXRvIXEzSZ14H6y2KAJShkGZRGC1ts7eRkYKkPvYYCMhsXPvuo2JLj3ZgeQwfQd19HShC/wXz+lh/88YSH1lZS2/91c/doTREHccuexwzEdvQ436uWGs4vU0XEmngHwv1ydrLfsciY2GnZFZcvic9EWDULh2k+9RG4Xdsgz1BUjpUTQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpJanDluOcxXg+UPLoRWZwZJyJouyF779vtVpsAyzyEsB7M0sODS8r8NXrQhhy5+oKYzPqxoS+/aJteIIHNnLmoVDc3/OpUUHuXJ6qHALfIp4aDQv1Cx+uFNTsZYtsExPPsdueCZT3fQeMM/cvSeRYg+RCnXfaMke96iR41xrUIthIKnSP8y8Ujgbtz5+UgwCU6an5tmzVDIvgOAG77tBIc+t1Win2JnEnnnoc4d+iYBvvMQ7Vu9Uwhv3aGGNOLsgx4h5RdrKDOxeHQ/xnH2+zkTzw81rOYUgqVG/1sgnyi5uCea5nr0RB8rFVaHeerVsrgklBhdLj9C+CkNBTyYxA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 27 Jan 2021 09:06:58 +0000
  • Ironport-sdr: C+6/zRJoPKr958V8W5hYDkjZTspowD7w4IP/fPfrymeOLewiaPNLL96LBhj9nEXfgbhgMTIfwJ Yittdcg0NZvBpIMiS0i+g9NfP8wvv7JgK+EgKUFh7/QoP/jeptuasThFa2VOg/iuCh6uMtXwBE C/WUMusRuaCXoDTV6zf7eSGIBcTmFSwNrjPm8R3aYvngbhgevPlPU5M7LlOzLdK3dsEfvKvxC6 Pz4SHcaSZI1Mhnb+FZWTHpHGZVRVTJi4hQoNvjHgdWKNQSz8zkfMnj21JgkMbW0dT3NfgrDJgZ Exo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 26, 2021 at 11:42:23PM +0100, Manuel Bouyer wrote:
> On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote:
> > [...]
> > 
> > Note also that there are networking modes that don't use a bridge, so
> > you could likely end up with nics[i].bridge == NULL?
> 
> I couldn't cause this to happen. If no bridge is specified in the
> domU's config file, qemu-ifup is called with xenbr0 as bridge name.
> 
> I tried this:
> vif = [ 'mac=00:16:3e:00:10:54, gatewaydev=wm0 type=ioemu, model=e1000' ]

Right, that's because libxl__device_nic_setdefault will set the bridge
field to xenbr0 if empty.

I'm not opposed to this behavior, seeing as we don't have much other
option I'm afraid. I guess we could open the tap interface in libxl
and pass it to QEMU, so that libxl can call the hotplug script knowing
the tap interface name, but that seems non-trivial.

IMO if we go that route it needs to be documented that NetBSD only
supports bridged mode for emulated HVM network interfaces for the time
being.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.