[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 28 Jan 2021 14:49:36 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HCSCGnCSRg4OJUsiYbqhdxEVzBRE9/s4f6rJxtBLuPU=; b=DVD2oRD9tkYzwLMLdKqbZ5HAMtQVcuXbK95lbox3HVxbro2bW8YaDnX8WkP3iD0BGro+eLwzyZRfQKTt9zr6/RUN357Ogj3ZkGiv6ybX2eqAnyQTHoC8WKjPyby/9xDl686ZFO/3GgBmU6ijvJ9i2dgb+CjljRB6gPfYp348satkdk04IJymN4xb+Kq2VlUm2rwMvuhpWihbAyU8/TygnFy0W/M5a+u1oeGmytWsCruOLmcV4QjAlRf5I3taAdBdENZNyIsbPUPGCqVaUM6Dj1fBcKgO8brFswFNPQ7HLtZtWdiN4tGsbCLjryFOuB+hDGdbvlhCTn7rkaiI4ietCw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DLgh+4EPYYNxvGN4ucMHzRYej8Il01A7EcsSrTm8zswQsuAaQ4RCGOorxGXjWS6sRW6Uo+bykXl+6rn5ujLgoX4N1hcUvGCCBoclRHTmmEPuaIASyVOJtIy6XdBIMUV43fOJStGDLTD82kyY7WHRTf7dZMEHq+0vUsTDWi2U8tE4Lh/oKGv4UYNFRQS3eJGrmcnv0PSq8I2oj6KEU3ETlS40FhOiK7iccrWJ6w9eiliF89T9KI0EVw+YaxdlehI6nCnkAj+Id7x04bE/07NX7hhlqSc2TrqtbKOrO94+al6OrZK0RWX2QNoIOCcbEXH7ZFDPCNVxkseTGcoP8zLw0A==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
  • Delivery-date: Thu, 28 Jan 2021 14:49:58 +0000
  • Ironport-sdr: PKlgpBlDcTVZnmW9gw+5bGQlnbzODbQULIsAcRdu5yy8zVNvh/YBea2gvgJh9c6Yqr+dQVutAL 1B4cYemfTu1CJ4bXO0na2Jz+YAGvIvBF8NZtqBJgxRIM7BP49U6xxPcjoXRN+kD0Z+aiH/oPwW pZix43mtkkCLxg2VIQGOQy9v8uxdbxGc0zuB45bNBaOdUaq4dMxHd3tnBbv7s5EM7syRApaYRO 1r+Xc6ciHhtjINtCRnGKwqjEWAXRd+T1YS15RIa2f/m33xsVJXfyGVQ1TXqXHF8Al/O67Tr1dX Rjs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28/01/2021 14:36, Jan Beulich wrote:
> On 28.01.2021 15:21, Julien Grall wrote:
>> I was going to reply back on my e-mail with more debugging information. 
>> It seems that this is a build issue as if I clean the repo the error 
>> disappear.
>> The error happens when I move from staging to a batch with this series 
>> applied without a cleaning the tree. It also happens the other way 
>> around as well.
>> Removing entry.o or asm-offsets.h before building doesn't help. Any 
>> other idea?
> No, I'd need to know how exactly to repro and then try to debug.
>> On a side note, it looks like asm-offsets.h doesn't get rebuild when 
>> Kconfig change. I noticed an issue when trying to turn on the perf counters.
> That's bad and needs fixing. Assuming you mean the kconfig change
> in fact incurs a change to asm-offsets.h. Otherwise there might
> be a move-if-changed somewhere preventing unnecessary rebuilding.

FYI this is the incremental build breakage I reported in IRC last week. 
There is definitely a missing dependency somewhere, but I just far
haven't been able to precisely what.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.