[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation: add a build job with NR_CPUS == 1
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 3 Mar 2021 12:57:52 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LznaiZPkrQDxsg0osJgpGB9a1nFePR57uEAvEfipNMg=; b=PjQG9JJOgR+4PK91RoffUxJ9vr+oaqgh2LdOMukLkYM/SSTY85/24vdiQxNfuqrx1G+GDiiVH/7UZjSnr3cLUGI7WAvtU66AlZPjK/yAbw/NwLMSP03RcXMHIZYXPkLJjS5Z+6xKZebBGAWvr9Ztt8u2lWcxhGoGoEtz388XKa4UWVRZFHOXYIaHAtIB4E0KML1EVTDQF62fx4G1XEHPju7846lAMG7rGmL7I4PEARfQ19EZvgyVJhLeU7Wo8qf6jAE4Cmg6uKh4eoEq4c8++GD0CN9VHw+qnqmNtKamYk956zXsCwMcIePftgr6vKQVW6LzdxVBMjjgoIzevknqYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8cUMVp0wBbYlu78a7j25/4QqEVJ321vxUXsUI8oXUvtE7Dm4vFfpZNx/Xae81v6RA9LQRBnpECZO31VM0EUXdS2NnafLzRx1dZl5hBmjar4B0qXMQ1F/HkVHZPtuJecYGqzpHhIy3UcPuixDkjViCF0/s7xXI8HP2ufuEyun/j+3ReniX8XI/rKYkFs4l1cGG86G4XkgN6ZIEhoLUwXqdZH7K92K85NyWf/z146S5xKqPPhll9H+NTf+FR4gni7RJxWyWLcjmJgUnqkVfG0sjUWg6RrM6jGUntB/l3jDcp6CRPYIh9/OP7glNZjN/1tSPUwrnep7BIfjjW/6ah4dA==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 03 Mar 2021 11:58:38 +0000
- Ironport-sdr: LQ68EadTl2Pjqcz9bbB3gkMEGXZB+Am/PNjr8zfJnQTrjLpCROox5891k7KBRw51tkC7Qjq3aw cEn49iqX43m1gC6fLBbrpS4vj2IbsaDmwCahojKkMBPGd1/4+jOoV8QKp3OJSAdHzzUFBzCGJG n+iNUvrHCyjFN6Wl912dP7va4jf1yvssIaKGFzJTlfyuj2nii5akfY1I5YctTBgWh3ePCFxkj+ 1XCfSytwK5tJgKL0cMUuktY5E9G71ZyJBBRjicIx+Gp1VKA/awYhTdnMywFMMvAg2iff/+1EJb 8aI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Mar 03, 2021 at 11:46:44AM +0000, Andrew Cooper wrote:
> On 03/03/2021 08:33, Roger Pau Monne wrote:
> > This requires adding some logic in the build script in order to be
> > able to pass specific Xen Kconfig options.
> >
> > Setting any CONFIG_* environment variable when executing the build
> > script will set such variable in the empty .config file before
> > running the olddefconfig target. The .config file is also checked
> > afterwards to assert the option has not been lost as part of the
> > configuration process.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > Not sure whether there's some easiest way to force a config option to
> > a set value from the command line.
>
> I'm -2 to this. We've already use thousands of machine minutes per
> push, and this corner case isn't worth adding another 30 minutes or so
> per push.
In fact I think those builds could be hypervisor only, which will
limit them to a couple of minutes?
Would that be an acceptable compromise?
Not just to test NR_CPUS, but in general for testing specific Kconfg
options.
Likely randconfig should also be an hypervisor build only, there's no
reason to do a build test of the tools with a hypervisor randconfig.
Let me prepare a patch for that.
Thanks, Roger.
|
