[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation: add a build job with NR_CPUS == 1
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 3 Mar 2021 12:00:44 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nllq/LR5NUkr2g40riYpZbZo/deabKkVCzcCfDWoVzg=; b=XBfAkbfrOJAjqJKVtGOwQwJ15bI1NE35+pH9CsNZ78/xK26wSRw66ZAxFKdk8irSJkOlYNIqtFhH2L3IsDAg5ZGpMxQ07vaSTSO9Q/9puDQZya0PX18wdFdgxcmkkgcdT4lwGrytXHkP1za3fuRqCZIfUj4X72GXSg9aTxzNGaHrMsyXZ+/t1Q8k7uaxrjaKpXNt5bBuRYFQqB96cwr34D3NdNE4AjHi+Cb+Frl/Vcmg5EofFvZ98BlyARoFakz6DUOyGfoYbBk5EPTS3ZSa0Q/3By3gMIkjkt4SFZgyZ9S/hCB+y31hqh2H3Z4+P5bzo0/ty5Hji5+qaWKTgnPgFQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkIDvbVodf68MZl8MX2MPwSkewcAJACYfu4HCwrfSX1leR/sToSn0Ez1FoVjA/TIi+5cSe27pnDWKHYvpoxCHsYkY+vm6zoQsT6VhmtEp4AUe0zZlx/OYkJNHdW8i/anzi0JL7JpFHqqhxiXH0zFa/ubXlH2gX+ONmnYxoBrWxQAgttvDWFUkiHm02Jkkpl7973ECF1hqsJ4Q0EUQv7tX9AZBR6BE69gEbwS2L5mtaiFM5Du5MJwLOOW7lDNvbXF9FotAEdlA3obOhncwsiqknJNKce6mycls3k6jGuecrcK9rnvvJsBoqBLXVE58O0T0dh4vpoW1M1lPCEWR9ygFA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 03 Mar 2021 12:01:15 +0000
- Ironport-sdr: wUZhNSJmRzhrMDm2S0Xk+vjYcTOurCEAvsUG+CAEn3rWC8dPlh5S1MQb1aFhPeVheYxeIOt9TZ 6AQMXN1aiL+LCt11YWG09MoafAx3h8o2PVmLtQlFhQ1lUmgaYZp353yRWBcy3iuQKlBXSmdxYp DunaExFF5RwVt/CT7PPyKCh7zJQ2u3dHR0FzBULnOuUdDFq90x9WTrEQUW4AAA63jx+7T1FDLe Ub+2FCVfCLmJGM/NmA9dV1zzJhiREzX+TZC4mfxKmnUo0aK+swVi92fUoauAjEWg5xr1U2HpF6 f4A=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03/03/2021 11:57, Roger Pau Monné wrote:
> On Wed, Mar 03, 2021 at 11:46:44AM +0000, Andrew Cooper wrote:
>> On 03/03/2021 08:33, Roger Pau Monne wrote:
>>> This requires adding some logic in the build script in order to be
>>> able to pass specific Xen Kconfig options.
>>>
>>> Setting any CONFIG_* environment variable when executing the build
>>> script will set such variable in the empty .config file before
>>> running the olddefconfig target. The .config file is also checked
>>> afterwards to assert the option has not been lost as part of the
>>> configuration process.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> ---
>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>> ---
>>> Not sure whether there's some easiest way to force a config option to
>>> a set value from the command line.
>> I'm -2 to this. We've already use thousands of machine minutes per
>> push, and this corner case isn't worth adding another 30 minutes or so
>> per push.
> In fact I think those builds could be hypervisor only, which will
> limit them to a couple of minutes?
>
> Would that be an acceptable compromise?
>
> Not just to test NR_CPUS, but in general for testing specific Kconfg
> options.
>
> Likely randconfig should also be an hypervisor build only, there's no
> reason to do a build test of the tools with a hypervisor randconfig.
> Let me prepare a patch for that.
This is already a plan for the CI working group (along with other
randconfig improvements) but it has yet to be implemented.
~Andrew
|
