[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Use register_t type in cpuinfo entries
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 11 Mar 2021 10:26:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuNJ2+CnWrPxceuoCyo1ZM+5HwsOBWqSU3aTw+TBMDc=; b=HwPapKJnjRLgxoresQNDIFB2dGXeMFWjU5jzPEZbx8whmx6mWgkUNOr15okljeCflICXi3h6O6VEcoSliOIOm9Amo2KdM4n7EiILdspCG05YjZyFxMM2ngO65W2y1xyYlrrwSArgsH7u4V4YG5xRQMYK+AH55Emp/ZLl/Fz0Utj8T6LzYf+mMAtEvdwHrdBV0fxz4QVbo9rjEy0rzSBavSqnjfLG30dMihHOU90hYZVQqJgIGQURMEhN3DT8BlMvHb+XwdkyVGUU8m6AWnHzNTxUBYWeC0LJeilJPeXbhbchbCMLkte4Q++exqDi7UZePBX5QWyIcySfSQjiJjlyAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FTndZl3nOnI2e/8MZmVnZzbyNqZq7+XDd0L4se0UB+oPfHP6h8+olXzB8rKfnlwOaQWqPKDs8psMmw55Jo4kkACZceHYOLH6jILOyeuz4ipxsFtK72BTnBz/R0KlYafoG1n7DdaE4b172+tpkUVAvz5f72Iq1b3My0Ll1A3cdkd722lBWBJUVjncvNQRLqke+m/6x0/knJKTouYX7oI5m2FLDHya15asx81rMkhlzfOtxnRtM1RlSZRR06psz/5+jq48QLWOTgvlo+DRbijVa3ib6BKffte1azW8Psd4BnAXpxfVB5xY7TgzQe5ZAzIuh97he/jsUmRxAeP47SuBGw==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 11 Mar 2021 10:27:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXFFQNaLCX4oSw+0OC1jGtjtl2z6p7f0oAgAA8pICAAtmcgIAAA9UA
- Thread-topic: [PATCH] xen/arm: Use register_t type in cpuinfo entries
Hi Julien,
> On 11 Mar 2021, at 11:12, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 09/03/2021 14:41, Bertrand Marquis wrote:
>>> On 9 Mar 2021, at 12:04, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> On 08.03.2021 20:48, Julien Grall wrote:
>>>> On 08/03/2021 17:18, Bertrand Marquis wrote:
>>>>> --- a/xen/arch/arm/smpboot.c
>>>>> +++ b/xen/arch/arm/smpboot.c
>>>>> @@ -321,7 +321,8 @@ void start_secondary(void)
>>>>> if ( !opt_hmp_unsafe &&
>>>>> current_cpu_data.midr.bits != boot_cpu_data.midr.bits )
>>>>> {
>>>>> - printk(XENLOG_ERR "CPU%u MIDR (0x%x) does not match boot CPU
>>>>> MIDR (0x%x),\n"
>>>>> + printk(XENLOG_ERR "CPU%u MIDR (0x%"PRIregister") does not match
>>>>> boot "
>>>>> + "CPU MIDR (0x%"PRIregister"),\n"
>>>>
>>>> For printk messages, we don't tend to split it like that (even for more
>>>> than 80 characters one). Instead, the preferred approach is:
>>>>
>>>> printk(XENLOG_ERR
>>>> "line 1\n"
>>>> "line 2\n")
>>>
>>> Except of course you want to repeat XENLOG_ERR for the 2nd line.
>
> Interesting, I always thought a single XENLOG_* was enough for multi-line in
> the same printk.
>
>> Very right.
>> @Julien: feel free to tell me if you want a v2.
>
> I would prefer if you resend a v2.
Sure i will do that.
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
