[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 11 Mar 2021 15:18:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wZ+hrFI0aAgo8+DuTI/aKLatz8Ixaoah2LZAayXwD9Q=; b=oIFTNstPZEQe94dK+yH+4JziksxXuZHtnzespRyLVoTpgP2qROJOyffHs9OuTgeexlWiFevcjb4rmGG2cImIMesjZQDCP+hG37spe/bWcphFgABUlVbWOjSWiEJBwhukvwVgycgWqtPt/GgTLNl72LcapBeO6JRrUTvHbNUh50cJ/KMR7KecuE/RLtW7Gxbe3Zpm4+vGf2YM8lBYFo5e/sdqLS9RIrxeY1DyRrCMqwJ3zQQCtjWHQy1fOOxe+T21NsCPuUi20c8PLfwArTTzjfCH5nIO7PGHpICjqA5UxM+R1XFvz9AwxbcDK9SekzEXRbcsEjypXwg5Ajn92mf+Lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pfyav6V8RenKi/rY0P9dqvFwCXh08PdSALn9Y/PQ7E/v7qcXwOPe+4MD4790aNquWw1tR5ZyOfy3b5VqFCTZ/v5ZLc5M1dZbC40c4+tyuas3p2cQkWMXf8hCzW3k7boUjKdyUKHkGLMTFm4EP3NF7K6fcuiAcLXAhzIymF+fN1np2MBfnutOe9RJD9SeZIBuQeC/G1yQXqyTOuUk5doBYA6bXHEzNUuGGsVA2Cn1drs6Aafh/DLZ2nnEqZzUFJXqQn3aFV31aXzjhcp1uZwQ/0Er2449nTTzzZ+ReSDR3w0tSz+HYIoLR/tzBVIgegc3+M8ld6yqC71Irc6MqSAQAw==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 11 Mar 2021 14:19:01 +0000
- Ironport-hdrordr: A9a23:XREfDaohlEBxgh8KoA4cNGsaV5sOL9V00zAX/kB9WHVpW+STnc y2gbA/3Rj7lD4eVBgb6Km9EYOrKEm8ybde544NMbC+GCzvv2W1JI9vhLGSuwHIMSv46+JbyO NcY7FzYeeAc2RSoM7m7GCDYrMd6fad9qTAv4jj5ldrCTpncqRxqzp+YzzrdHFeYCljKd4HGI GH5sxBzgDQCEg/SsigHHEKU6ziirTw5fbbSCULDRIm9wWC5AnAgNSWfySw5RsQXyhCxr0v6w H+4mvEz5++uPK2wAK07Q/uxqlWg9fox59iA8GBm6EuW1fRozuof4hoVvm+uik0qoiUmTUXue TLyi1PA+1Dr1f9Xkzdm2qc5yDQlBIVr17r0xuxnGbqq82RfkNAN+NxwaZiNib/x2Vlltdmy6 5P13+erPNsfGn9tRW42NjSSwsvrEC9pn0vnIco5EB3QM8TebVVpYwa8FgQFJpFFiT854Aoed Mec/309bJTeVOeY2uxhBgT/PW8GnIpHhmHRUAeusualzhO9UoJs3cl+A==
- Ironport-sdr: SnZPWjFIj1W4lQ1z2CmaHN7OtMa9Hf1OBwBwN8Yhj/KpTIgk7ydvzNvL6B5XXtBz21CsmGuTu4 osZKq8onbLctybl/BPYqsOBdbcy4NkIoalgARyZKzQLfnzCgtgDO4bLdttyH937g5+cEtf5peT H5r72KGE5WgtDW+NPt6yQsGYb7aUxSQao3qEFaNfTma1//6L3us5KVqddap0Wzn7zNT5GJluHe vJvsPS0y+zGI8jaWHbIDsccJE8VGYg8+qyc6dtyeoAQxvCR7e8XlxxOpEtIutFN6Tnx2a7p2h6 wnw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 11, 2021 at 11:05:32AM +0000, Andrew Cooper wrote:
> On 11/03/2021 08:27, Jan Beulich wrote:
> > Depends on what __XEN_TOOLS__ really means - to guard things accessible
> > to any part of the tool stack, or to guard unstable interfaces only.
>
> As far as I'm concerned, __XEN_TOOLS__ should always have been spelled
> __XEN_UNSTABLE_ABI__.
>
> For better or worse, the fact that we currently do have unstable
> interfaces, which aren't in an obvious namespace such as
> xen/public/unstable/, means that there is some value in some form of
> protection to prevent users from inadvertently using an interface which
> will explode on them with a mismatched hypervisor.
I think using __XEN_UNSTABLE_ABI__ would be way clearer than
__XEN_TOOLS__, or even placing those in a separate directory as you
mention.
Thanks, Roger.
|
