[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15 v2] xen/dmop: Strip __XEN_TOOLS__ header guard from public API
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 11 Mar 2021 16:23:44 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQ7ev8qs7TpjwyDBLnfCjdfEo3ugAzrS4IdLwHUtvBQ=; b=Oh4pN0Nke0WlDOE1uwgEx7db7ze+j/LnXxsx0OVnBNYtXHVKUC4N79V8ZPDocfzAVV7o5wpKzd/cdxaGLd++krc42kVjKPzhYQiK5Kx/mdyAOps4oDZWpD1yWmkR3EfAeJmLEvNUXMBErb3mmJK2jWG7AmJ/9CT+EbeqbPQusiOTiupa178kL8lUsKK7KF49VTHRxjuKDyzWLXdI3SZeJxi/QRFQTeHwlRRTbFrXNQtG3Kc8Skk9oz40SqdefJJiizmrK49guVO6BIjm7xOmuje+yuxyB21PTskzyBW9ywNS/PCri4+WTR+EYdsDi9gEkjGuPSwwnh+YEHjjlEPJ9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JX6zmyWLZRFYY2Z98NScYCj0+59Q2nKJOmvw3BgBZj5KrareheY9NrfXkhqWg3WppGR1VE5YxYFTPKPphektJFlIh6NhiNzfnzpg9AnlX6OPZM0LHbXvYOl2v+bZnuvm47OkM6KAZmrPs1ctHIx4p+sovgIqdEBhx61uA1ewU/vZW6qkQJlg2uI/m6u4T1E9GFcsjACGwhuuTM/8kSINCdEXzT1HcuPKaFHuknPPSq5EQguPx3Lc0yT8ebf5cILFlUxmu9WJoz8M7/TQ+0jEpxLl9L2Qpg/RhtTt85w2VrsaXx9g/enGLoXFpo3zvyzQasOitWUYCOrIbgOIz0cpAA==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 11 Mar 2021 16:24:43 +0000
- Ironport-hdrordr: A9a23:vJEpCa7tmP42vEooyQPXwWWEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbjqzOEtwWQVAGN4dHJ 2T+sJIq1ObCAsqR+68AWQIWPWGmsbCk4jobQVDKxks7gSPij3A0s+HLzGz2BACXzRThYoz6G StqX2F2oyPkdGejiXd2Wja8ohMlLLapOdrKcSQhqEuW03RoymyYoAJYczlgBkUp6WV5E8ugJ 3wpX4bTr5OwlfwWk3wnhf3wQnn118Vmgzf4HuVm2Hqr8C8ZB9SMbs5uatjfhHU61UtsbhHuc ohtQLp1OsjMTr6kCvw/NTOXR1x/3DExkYKquIPk2dZFbIXdb45l/1uwGpuDJwCECjmgbpXct VGMce03ocyTXqndXzD+kFgzNuwN05DZSuucwwpv8yY1CVuh3Zpz0cU79x3pAZwyLsND7ZD/O jKKaJuifVnSdIXd7t0AKM7TdKwEXGle2OCDEuiZXDcUI0XMXPErJD6pJ0z+eGRYZQNiL8/go 7IXl90vXM7EnieR/Gm7dluyFTgUW+9VTPixoV1/J5ioIDxQ7LtLGmqVE0uu9HImYRdPuTrH9 KIfL5GCf7qKmXjXaxT2RflZpVUIX4CFOUIp9cAXU6UqM6jEPyrisXrNNLoYJb9GzctXW3yRl EZWiLoGclG5ke3HlDihhz8XG7sZ1zf8Zp8HLOyxZlX9KE9cql39iQFg1Ww4c+GbRdYtLYtQU d4KLT71oO3zFPGuVrg3iFMAF5wH0xV6LLvXzdhvgkRKX75dr4FppG6cWBW132XGw9nQ6rtYU lijmUy3ZjyA42bxCgkBd7iGHmdlWEvqHWDSIpZvaGf+8H/eNcdAow9UKJ8USXHfiYF2DpCmS NmUkspV0XfHjThheGOl5oPHtzScNF6nUOMOs5bqXXWsG2GvsExTn4nXzqjOPTnwzoGdn5xvB lc4qUfiL2PlXKEMm0kmtk1N1VKdSCqGr5cNR+EY49Vg7jvXwl1QQ6x9HqnoiB2XlCv21QZh2 TnIyHRXf3QGFJStkpV1bvQ/Epuen+QeF9xbX5GoZRwfF62yEpb4KuuXO6ewmGRYlwNzqUmPD bJbSA7Dyluy9q0vSTl0gqqJDED/NEDL+bdBLMsf/XvwXurMpSPjrxDNeRT5oxZONfntfIrXe qTdxSOFi7xD/ok1mWu1y8YERgxjENhveLj2RXj4mT94WU2BuDKJk96A54cONOR4gHfNr+1+a Q8qehwm+S+Mm/8MIHbjY7WaiNOMRPVryqdSfoypZVdoKI1s/9SEvDgIEz1/UAC+C97CsH+0H 46auBcxpvqP4d0Zcwcey5D5DMS5Z+yBXpuljazO/M0eFEmsmTSMNyI6YfZsLZHODz0mCLAfX 2ktxBH9/jLXyG/xacXJqI5L2NRclU94h1ZjZW/XryVLAWhbOdY+lWmdle7bb9GUaCAcI9g4y pS0pWtn+WNcTD/1x2VlTxnIrhW+2LiZc+pGgqDFapp9NO9UG78zpeC0YqWjD3tTyG8ZFldrY pZdVYIZsAGswIctuQMo2CPY52yhFkknVtY6SxmkVCo+rHO2hakIWh2dSvDgptXWjFPNGOvls qty5nB6EjA
- Ironport-sdr: CA5zbA6Nsun6Gtsv9Z86vUbDihZNYmYcjOgb+WKbgD5kX6lrRnuFuiefBZixULOjy5esjfvlh/ 3JYP3AgP0Pp+mNfFqejM6zH9rwRCCFzDt3uREGtWVIQhu0Bv5+Z8R7XtGJm/XFJT+iKEMowm35 HpYz3djOtekEkUe1jBCzsoMiibTGpOQV7SubRXgEevfJsnx1fEZ8+fwRNeEtxIv8o1wzx5BMd+ ROfmspkl1hJrnX7esNO88DWvzlBN/ON05MLWSQvSXP/izb6yhey03jvd8uQs0YgAZSPidaXi6b m0c=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/03/2021 14:18, Roger Pau Monné wrote:
> On Thu, Mar 11, 2021 at 11:05:32AM +0000, Andrew Cooper wrote:
>> On 11/03/2021 08:27, Jan Beulich wrote:
>>> Depends on what __XEN_TOOLS__ really means - to guard things accessible
>>> to any part of the tool stack, or to guard unstable interfaces only.
>> As far as I'm concerned, __XEN_TOOLS__ should always have been spelled
>> __XEN_UNSTABLE_ABI__.
>>
>> For better or worse, the fact that we currently do have unstable
>> interfaces, which aren't in an obvious namespace such as
>> xen/public/unstable/, means that there is some value in some form of
>> protection to prevent users from inadvertently using an interface which
>> will explode on them with a mismatched hypervisor.
> I think using __XEN_UNSTABLE_ABI__ would be way clearer than
> __XEN_TOOLS__, or even placing those in a separate directory as you
> mention.
I plan to submit a rename for 4.16.
I don't expect I'll have much luck arguing for a release ack at this
point, and isn't totally risk-free.
Re-laying-out the headers is far more invasive, and was also a trick I
was planning to pull when we've got a rough plan for the other ABI
improvements agreed.
~Andrew
|
