[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule



There's no need for the common "xen-dir" rule to have an arch-specific
part when there already is a arch-specific rule where this can be taken
care of (arguably instead of all-y this might better be xendir-y
anyway).

Also change the pattern from *autogen.h to *-autogen.h.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v2: Insert dash in pattern. Re-base over changed earlier patch.
---
I was tempted to move the "xen-dir" dependency from all-$(CONFIG_X86) to
the general all-y, but perhaps that's less related and hence should
really be a separate change (and there may also be arguments against
that).

--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -29,14 +29,12 @@ xen-dir:
        ln -s ../xen-foreign xen/foreign
        ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/
        ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/
-ifeq ($(CONFIG_X86),y)
+
+all-$(CONFIG_X86): xen-dir
        ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm
        mkdir -p xen/lib/x86
-       ln -s $(filter-out %autogen.h,$(wildcard 
$(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/
+       ln -s $(filter-out %-autogen.h,$(wildcard 
$(XEN_ROOT)/xen/include/xen/lib/x86/*.h)) xen/lib/x86/
        ln -s $(XEN_ROOT)/xen/include/xen/lib/x86/Makefile xen/lib/x86/
-endif
-
-all-$(CONFIG_X86): xen-dir
        $(MAKE) -C xen/lib/x86 all XEN_ROOT=$(XEN_ROOT) PYTHON=$(PYTHON)
 
 # Not xen/xsm as that clashes with link to




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.