[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule
Jan Beulich writes ("[PATCH v2 2/2] tools/x86: move arch-specific include/xen/ population into arch-specific rule"): > There's no need for the common "xen-dir" rule to have an arch-specific > part when there already is a arch-specific rule where this can be taken > care of (arguably instead of all-y this might better be xendir-y > anyway). Thanks, but I do not like this change. IMO make commands should be primarily organised by their logical function and role in the file. If that means that multiple targets have arch-specific parts, so be it. IMO it is not right to move something from xen-dir to all just to reduce the number of different targets with arch-specific parts. Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |