[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Create EFI_VENDOR directory
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 22 Mar 2021 17:08:50 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QPtX9B06g+oughc1P4agimdfnvEc+taVde1WpUDghLI=; b=ShB23OdYxPQjzdq5GTThvqHO0nZ2rP7pKbNz0JgFYneUS6FJzmkGlgWQgexeyxR8QVmplBJgiuzxWSpLVwty5wxWQkAeZwDB2oOMmuOZsmb+d+Ii5+7INX+5V4vAPteniEpp01SXb6TxhOHP/R/guoBba/WBfEeiUTeMQb4hKWEZv+ca6kBScCo3qJgEqKOER9pCvpsS/ymiZhvu9LRqUeef7IkWPetl8mItyBFoNzrJSRafx9Gu6KNn81Ysahzpgz8uojtSJEXY0Jjt1wdmbken1mle/U9uzN2xhfRntnZdJXGDvkopvHFTPLHSORFz1NqonBTTZHwhkpcKkJhLgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0029rH7hZKX9nAZDPefqX3dn88Ju/gMxDU6taYZgryYB6NMcAnhVyGvFQ6b06roPHEEeKD7u6H1Rb3CprOjeFB/oYUpSUBR69nenXjHOZx1eiFO6YHV1L4t2YxP8chWCnH3JwCaRkuZP5h05+dbl3o5yodfnvBhdql5vVHjTSTRfOqszCCfIKOhLbvhn8gzuQNoYwrmZxvTbaeJA7xv5LdgYkYbpd6ARS30PHfjv7XkSsGksTHhGHOs60wFGwZrQSkA2ZEwwFnrToWE6GqBCHGk1RdHyKeCOMLkuIXh+Nujzj+a4f11gtGslxi50UWdYbAvaTt8uIysoTtHhJZalA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
- Delivery-date: Mon, 22 Mar 2021 17:09:21 +0000
- Ironport-hdrordr: A9a23:c60wIaPE+EYqk8BcT4X155DYdL4zR+YMi2QD/UZ3VBBTb4ikh9 mj9c5rsCPcpRQwfDUbmd6GMLSdWn+0z/QZ3aA9NaqvNTOLhEKGN4dnhLGM/xTEGzfistJbz7 tqaaJkCNb9ZGIK9PrSxCmdP5IezMKc8Kau7N2urUtFaQ1xcalv40NYJ2+gcnFefwVNCZonGJ f03KMumxOadW0TfoCHABA+MdTrncHBl57tfHc9dn0awTSJ5AnI1JfKVzOZ2RofVD0n+8ZHzU H11yjCyY6H2svR9jbsk0vo364TsOLAo+Ezf/Cku4wwIjXohR2vYO1aKtu/lQFwhOm16lo2lv ngyi1QWPhb2jf0fHycuhHt2xbtuQxek0PK+Bu9g2bGqcz9aRAbL6N69PhkTic=
- Ironport-sdr: QhDkJ2biR9Hhp9G0bkt2a+0qgwDYk2FeLvotNXhS/9r+7Uy5L4NqW77n2AJlLpUNTdqUmfAyow ANkPX9BX09dpvkKqkbDbc1ZvBQKvCRLu7zIzefkIzaTp8IV5JBgI0XQqCmvFHXfuT+b7XPo69L G4gu9crGeGxavK28UrYfgknG9ojEWsnm47dcuCDNwbMcs8YRKHgHlQcn1/09+vlte2+w0DrN1F 7GXMaOggpSwesuzdyzzi/uydbNeI1ygyY8e4YPfjFikwSgdnLnRx0XXJyC4JcuNmzz1ZSl5kCw 0f8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/03/2021 15:15, Jan Beulich wrote:
> On 22.03.2021 15:59, Andrew Cooper wrote:
>> On 22/03/2021 14:52, Jan Beulich wrote:
>>> On 22.03.2021 14:33, Jason Andryuk wrote:
>>>> make install-xen fails when EFI_VENDOR is set (=fedora) with:
>>>> install: cannot create regular file
>>>> '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No
>>>> such file or directory
>>>>
>>>> Create the EFI_VENDOR directory so xen.efi can be installed within.
>>>>
>>>> This removes the need for Fedora and Qubes xen.spec files to manually
>>>> create the directory in advance.
>>> While I'm not strictly against, I'd like to point out that it was
>>> deliberate to not create this directory here. I also didn't expect
>>> anyone's xen.spec to do so. Instead I'd expect the distro to create
>>> it during OS installation. If this was a bad assumption, I'd prefer
>>> if the commit message here could point out why such an expectation
>>> won't hold in general.
>> This reasoning is broken for anything other `make install DESTDIR=/` on
>> a live system.
>>
>> It is incompatible with how RPM, deb, etc packages work.
> I'm afraid I don't understand, for both of your statements. If distro
> installation put in place the designated directory, there wouldn't be
> any live system lacking it, and there wouldn't be any concern in the
> packaging of any software.
>
> To take a perhaps too extreme example - packages typically expect e.g.
> /usr to exist as well, don't they?
No. A buildroot starts out fully empty, by design.
The packaging environment (usually a chroot) invokes `make install
DESTDIR=/path/to/staging/root` so you don't interfere with any of the
tools inside the environment, and the resulting tar/cpio has the
buildroot stripped out of paths.
The failure being discussed here is the build within the packaging
environment, not the metadata which forms the final package. Installing
a deb/rpm/etc will make directories as applicable.
~Andrew
|
