[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Mon, 29 Mar 2021 16:06:57 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3CR131yJiWWFWbUKZDOwdpvolB7189ggeoOD2BlBJM=; b=dVFR1yBAqfm273gSh3TFWOSGrgQtXzYiZe3ICmWykJej/BjY7qruBwS6vylw37yiLT6T//naxGUKjBk7irsK4YrfnEB4etRktkOmZgRVWMHHvGK8aw8Km0g+NXFTo9s+maNc7aSmJlDHSO82RfePCS2Ae6XQgR9bCoARqzlDrZ+FpQMNGUIkVfLSSsymdk+9vnqYpHchDSCx6R9bTXlegw5Kyzo0FXNVL31K/Vfln2WGjDT1jGyOhfwsX81bk4rel9Dy2K35oHX/88XL7Zw94poTTE1KPFEo6IOFqufAvve4dve4r0cwkpBsIDXJPmbtHOi9ZIcyyJCJr2RtlYcNUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ce+zLn62myLLICCMQ5aEIQHpze92N5WKO2k7RJTDp+VKUp7FGXhIQesYpfBOeckBaXH/zFx19pVGwU66V8QpM1a7yY485OnBpI5+OrDpekoUUvF/5bX0seGrc+UccNfvIXgq0VUG9lZRQyYKj2rNaDIckSpsmGQsSGUPSrE+VeYnNq/5Nj0lwLaZPaSuAj9SEjhJB2YrGGpm+cejwn9ukJ1ouDO4FatGnTlXNriDDfSdBfBebcLqKAEXI6uuKUz/Pxog4LEfnGxNrk0Qvyd95TkJZgjv5o5Xujj7tx+Qe9+kLYCWH+FO6wEP5AJDoVjEkGWRvYz3cfkD+G5e7aYc5g==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Mar 2021 16:07:23 +0000
- Ironport-hdrordr: A9a23:p85Ez68UMZM9kzRMjSpuk+FfcL1zdoIgy1knxilNYDReeMCAio SKlPMUyRf7hF8qKRUdsPqHP7SNRm6Z0JZz75UYM7vKZniAhEKDKoZ+4Yz+hwDxAiGWzJ8b6Y 5Me7VzYeeAb2RSot395GCDfOoI5Pmi3OSWifzFz3FrJDsaLZ1IywtiEA6UHglXaWB9dP8EPa GR7MZGuDasEE5/Bq/QaxU4dtLerN7Gno+OW387LiMn8wWHgHeJ77P3AnGjr3Qjeg5P2rsr/C z5lRX47MyY082T9xm07QHuxqUTvOGk69NYQOSQl8AeK1zX+2CVTbUkf4fHgRcYj6WE7k0wnN zFvhE6Vv4Dkk/5dnq+5RPwxgjt1ysv4Xf+yVmexWDuu9D9WShSMbsLuatQaRGc70Y7ptlz3O ZQ32yfv4dKFh+oplW02/HBTBsvjEa9pBMZ4KcupnRCTIoTb6JQp4QD/EVTVIwNBj7+9ZpPKp gVMOjQ5vZTNUmbYXfQo3V1zLWXLz4ONwbDSk0GqsaR2yJNnH94xUMExMoZ901wjK4VWt1K4f /JPb9vk6wLRsgKbbhlDONEWsevDHfRKCi8RF66MBDiFKsdPWjKpIOy6LIp5PuycJhg9upBpL 3RFFdZv3U1YUTgFImH24BK6AnERCG4US72ws9To5h/tbuUfsufDQSTDFQvmdCnufMRH4nSXO uyIotfB7v7NnT1cLw5rjHWSt1XMz0TQccVstE0VxaHpd/KMJTjsqjefOzILLTgHD44UgrEcw w+dSm2IN8F4lGgW3f+jhSUUWjqYFbj8ZV5F7Wf9/QPyYAWX7c8/zQ9mBC8/IWGODdCuqs5cA 91O7X8iL62omGw4CLB83hpIBxAFUxYiY+QH09itEsPKQf5YLwDs9KQdSRZx32cPAJySMvQDU pRvFJy9aWrL4GBxCwrBt69W1jqzkc7tTaPVdMRi6eD7cDqdtczFZA9QrF8Eg3NClh0lG9R2S d+QR5BQlWaGiLliK2jgpBRDvrYbcNgjACiJtMRrXresE6btNw+X3dzZU/sbeeHxQI1AzZEjF x49KESxLCanyy0NGc5iOMkdFpBdXqQG7ADCAiefo1blvTqdWhLPCi3rC3fjwt2dnvh9k0UiG CkJzaTY+vXDl1UvW0d1L3r/lNyfmCUZFlxdXh+rI14GQ39yzhO+P7OYrD233qaa1MEzO1YOi rCeyEOLgRnwM3yyASYgy+YFXItxownO+vUCLhLScCQ5lq9bImT0a0WFf5d+5hocMrjteIGSu qTcQ6YJjGQMZJb5yWF4nI+fCVkongtlv3lnAD/5G+jxXglHL7ZO1J9XawWJNma8mnpT/uFy4 9ikNowpOe8W1+BL+Ku2OXSdXpOOxnTqWm5Q6U0sphSp7s1r6Y2EJ/BUzfEvUs3qikWPYPxjg cZT6t66ryaZdMqcMwWZi5D/l0m0N6IN1AmtwTqAuk4OVEh5kWrQO+h8v7Ns/4oBEbEuQ77fV +Y+CdZ9+3eXySC2aUBYphAUVh+eQw58jB64OiGd4fMEw2keOFI4UqiPhaGAcNgYbnAHa9Vsw 1z7N6JlfKGbib02Ajfuj1gP6JFmlzXP/+aEUaLAu5H89uzJFSKjO+r+aeI/UrKYCr+bV8Zi4 1DfVEXdcJZhFAZ/ckK+zn3V6zrvlhgl1dC6Txui1aoh9HO2hahIX17
- Ironport-sdr: dyp3wg/cEurzrVO85mPa8MlEgHzSILpDRTdlI1dPCCzrhYsrWFFLksWfRwseN78q5gIRWXd/gN JKAaPmk0GG+ORfcRiTTBgFmvGX20eoV881ViWOZVgNvpjviePkTP6arVChEiqnr/PxWKyv3oOL IJpxN5s9N/Xg9DDpEeCat4GF8ar3+83f9GxXqda+KMxa4lnd/EfWx8SgEOMkWZ9nQCsHyX++o/ u1zUNGFMCYMUlNTIyivmjfPncuUMrvoF9o+7+lG+R0I/0ZuOhBdoFBPl5yoLtjg+Q9vqPijyun m68=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXIMzvj/osZBndl0iN655u2tDs9qqUV1aAgAAS04CAAFJTyoAGVX0A
- Thread-topic: [PATCH 5/6] CHANGELOG.md: Add entries for emulation
> On Mar 25, 2021, at 1:58 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
> On 25.03.2021 10:37, Andrew Cooper wrote:
>> On 25/03/2021 09:04, George Dunlap wrote:
>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>> On 24.03.2021 17:44, George Dunlap wrote:
>>>>> --- a/CHANGELOG.md
>>>>> +++ b/CHANGELOG.md
>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a
>>>>> Changelog](https://keepachangelog.com/en/1.0.0/)
>>>>> - Named PCI devices for xl/libxl
>>>>> - Support for zstd-compressed dom0 kernels
>>>>> - Library improvements from NetBSD ports upstreamed
>>>>> + - x86_emulate: Support AVX-VNNI instructions
>>>>> + - x86_emulate: Expanded testing for several instruction classes
>>>> TBH both seem too minor to me to be mentioned here. If I was to pick
>>>> just one, I'd keep the former and drop the latter.
>>> It’s always quite difficult in these releases to help express to people
>>> exactly what’s happened. We’ve got over 1000 changesets — what have we
>>> been doing? If my star chart is correct, the latter represents nearly 1700
>>> extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s
>>> actually a reasonable chunk of code churn, which I think is worth
>>> highlighting.
>>
>> I agree with Jan. New concrete instruction groups are useful for an end
>> user to read. "We refactored some internal of a test harness" isn't,
>> especially when it would most likely be repeated every release.
>>
>> I'd drop the latter line and just keep the former.
>
> And then perhaps also not focus on the emulator, but merely on the
> fact that guests now can use that ISA extension (for which the
> emulator change is a [the only] prereq)?
Would you mind giving a concrete suggestion?
Thanks,
-George
|
