[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] x86: don't build unused entry code when !PV32
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 6 Apr 2021 18:34:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=moqfotm5duShMZ4N4znmFG9WmFdGzVoAkzbIKTRVweg=; b=F+wJdeBDSziZsX5m71+SDGagTGXaXG86iKE0DE3P1SY+c1++ddYmGUcsFF7d8XMMKkRmoYPWG1MO0dnGZ4u5ELha7fxKpPDfNh5to47tifo5eVhQ3r9/PEhiZBvj64Hn5efpChCzABOsfW67JA+47xlHmgC84/5Bfw03y3oyXghwwBubDmK1u8Zq6aThktyeLHas5MBUpl2c1bMUcDyfW09SU8X8BGvFOZdaEfAAdmgVng18NGR2A0sKAGiylmKucgmTyFVoR4wdhw0KgWSNH1nhQakMfpULJg+Pnrc/HY4vwv9O4DN6lJiyosOoUMCf2z+UvDvSEr9D6dEW6pktBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+aC5Aj4dVlUs9hZBk72/FoLSB5BE/lTmf921xqKnQ/ujk1Xb+MXb58e1/Hg6bzbBE3YyeoqTJo1cm94oqg0XSfHEs2le2h1h3H6cDUrwPhlUnT/5PfGyp/9SZsjeb2ddczLsTk1N8vzf0CwewO51oRH2+oKnq51jG6S78zEEk1bEVb/ammw8uiUAA93nPF4BD12VZT+nfbhifi5mV2tcoqsILSF7OciAwMIo0zqcppdvN6k/xRyeE32Vv8CjpLXqk1k7mhmfeYQOdU7iaPSr7ZyybFmhKNJxBc9qSDTknf1nRaz6alxqUnBkNIOqTM5hly3HDf6wK3QYiwwjLZWJA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Apr 2021 17:34:33 +0000
- Ironport-hdrordr: A9a23:CXDQ3asXaZ82O/0sJbe02tTe7skCM4Aji2hD6mlwRA09T+Wxnc qjhele8BfyhioYVn1Io6H0BICraxrnhONIyKMWOqqvWxSjnWOuIp1r44eK+UyVJwTV8OlB2a B8N5VvEdGYNykxse/WwimdV+whzt6O7byyiY7lr0tFYAl2Z8hbnnZEIyucFkV3QytLFd4CFJ Sa7tdavDbIQwV1Uu2VHX8ANtKz3OHjtJWjWhIeAg5i1Q/mt0Lb1JffMzy1migTSClOx7BKyx mJryXc6r+4u/+2jj/wvlWjn6h+o9fqxttdCMHksKF8QVSc6HfMFeARPMzlzUlF2N2H01oknM LBpB0tJa1ImgDsV1uoqhjg0RSI6kdT11beyESViXamgcv1SCNSMbs+uatlcwDU40dlgddk0K gj5RPni7NrC3r77V7AzumNcysvt0Kv5VI+jOYYjhVkIPwjQY4UibZawWR4P9MrGjng5IUuDe 90Zfusksp+QBehdnjc+kNvzNavUm92IRucWEgFvaWuuQR+rTRC1kMdgOkSgXsEnahRd7B0o9 7cOqAtr71KRt8NUaVhH/saXMe7Y1aifTv8dFiKKVCiLrwOJm7WwqSa3JwFoNuycJhN85sohI 6pajxlnH93f1irBdyF3ZVN/ByIXX60Wi71zNpCo5djvLnxQ6fqLD2DRFgin9DImYRXPuTLH/ CpOJxXBPf/LWzhXYZRtjeOE6V6OD0CVIkOvcsgH0iLv9ujEPygitDm
- Ironport-sdr: BCKVTVtazFFejypfh7ZYcICCnLCE6g1v4sp+Tz1Xpmi8M0ZMtJvube5YXdMsZaqaiIGXpFkIjL HPGVvrd91as/1Q46GgasXV5pNtf61NM6ZK5hqlziJVE5TwooFo8NiKkDn9WVJnOSBist6Vo2Y6 tmAA9iRJZyxNE+uHl+WChp9boXFQmwpk81XS4YilUecYO57c3fjjG/hDvNPg4vgNoGv8mjNW+E X4olrWr64RWpGp39JJMwrcM3lu5IqKNx4nm9+TLCforHt12foOcY79uN8wZWSsuL3u50NHvEVx g44=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/04/2021 15:37, Jan Beulich wrote:
> On 01.04.2021 16:31, Andrew Cooper wrote:
>> On 25/11/2020 08:51, Jan Beulich wrote:
>>> @@ -102,19 +102,21 @@ void __dummy__(void)
>>> BLANK();
>>> #endif
>>>
>>> -#ifdef CONFIG_PV
>>> +#ifdef CONFIG_PV32
>>> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit);
>> Even if PV32 is compiled out, the is_32bit field still exists, and is
>> still necessary for crash analysis. XCA parses this offset information
>> as part of dissecting /proc/vmcore.
>>
>> It's one single bool in a fixed size allocation which we've got plenty
>> of room in. It can and should stay to avoid impacting the existing
>> diagnostic tools.
> I'm afraid I don't understand at all: I'm not removing the field.
You talked about removing it in the commit message.
> All I'm removing is the entry for it in asm-offsets.h.
Yes, and that will break XCA, which is used by several downstreams, not
just XenServer.
For RPM package reasons, you can't use debuginfo packages, because
what's on disk doesn't match what's in memory until you've rebooted.
Livepatching adds an extra dimension of fun here. There's not enough
space in the vmcoreinfo page to pass enough structure information, so
asm offsets is appended to the symbol table. Yes its a gross hack, but
its how things currently work.
~Andrew
|
