Re: [PATCH v3 1/4] xen/arm: Move dom0 creation in domain_build.c

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 12/04/2021 11:52, Luca Fancellu wrote:
> Move dom0 creation and start from setup.c to domain_build.c
> on a dedicate function.
s/dedicate/dedicated/

I would also suggest to add "No functional changes intended" to make 
clear this is only code movement.
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> v3 changes:
> - move create_dom0 function after construct_dom0 and
>    make construct_dom0 static
> ---
>   xen/arch/arm/domain_build.c | 38 ++++++++++++++++++++++++++++++++++++-
>   xen/arch/arm/setup.c        | 29 +---------------------------
>   xen/include/asm-arm/setup.h |  2 +-
>   3 files changed, 39 insertions(+), 30 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 374bf655ee..359957dc1b 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -21,6 +21,7 @@
>   #include <asm/device.h>
>   #include <asm/kernel.h>
>   #include <asm/setup.h>
> +#include <asm/tee/tee.h>
>   #include <asm/platform.h>
>   #include <asm/psci.h>
>   #include <asm/setup.h>
> @@ -2520,7 +2521,7 @@ void __init create_domUs(void)
>       }
>   }
>   
> -int __init construct_dom0(struct domain *d)
> +static int __init construct_dom0(struct domain *d)
This wants a sentence in the commit message. How about the following 
commit message:
"
Move dom0 create and start from setup.c to a dedicated function in 
domain_build.c.
With this change, the function construct_dom0() is not used outside of 
domain_build.c anymore. So it is now a static function.
No functional changes intended.
"

If you agree with the new commit message. I can modify while commiting it:

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall