[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] xen/arm: Move dom0 creation in domain_build.c


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <luca.fancellu@xxxxxxx>
  • Date: Wed, 14 Apr 2021 05:22:55 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sT+B/WxYxeliHMZY1kqp18MVG23xqileWEBiXhbJ4qg=; b=RHTYQJ1ozRxR/yZ7Kw+I+5FSAaLMCrWiHR6smdeJ6TRWMcA0b/VycASDQBiYdSfb4oYqH+y29BNNP8A34UVHsSH4QQKR3ewRRSSLWuPIGE3ox6u8NXAKPpeqaJiCqmrTkj/r2+cxKDLO9/54Ixsb+zanLtJuCmCLfRGt9XbdhgSBqvIjtPsPmJv4a6EantU3wQidtCtTvGzOq2LUBvu0dkUmM3Fb7JlKubKyENz3tqBKfbO5RUZoalVHsM8wDF07ENvgqlCAsVd1n+JQtOrjsS30h3AiA6qczLEj6SZCRLE9bJANyv2UyPxk4CNrPbs1gI+hSxtKgEjoE48u/o40OA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N387U4VQGU9825so8WDoUUxf9AODYwLlUryruauTiaflbyXfkUw7YcwFfYUK0z8YAT2+GmmJP+s7nxiTBWW3aCml94BQHbCLdwQ+OyP3PkOqbMkkbOqavE7p7p1t/+WSk75h6CKhZKRJdE7k9nEazyiWivk7a0J7WIEBhdF76he0o+UQOL+0M4KsxeGV5YnxPIBFx3CeRolE3O5jmdMEVgLGg94Rz5srpGfkJXzrQmuRJcRFnEf76SABVH3IeEdXpOaOEKRt0fSKuWkvcn55pew9qjeVG85W1I2Rr2+P/czoTACCfL2AK2PsKeHxMx289b1sRpEmFv1jm9bTi0W2IQ==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 14 Apr 2021 04:23:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;


> On 13 Apr 2021, at 17:40, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Luca,
> 
> On 12/04/2021 11:52, Luca Fancellu wrote:
>> Move dom0 creation and start from setup.c to domain_build.c
>> on a dedicate function.
> 
> s/dedicate/dedicated/
> 
> I would also suggest to add "No functional changes intended" to make clear 
> this is only code movement.
> 
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> v3 changes:
>> - move create_dom0 function after construct_dom0 and
>>   make construct_dom0 static
>> ---
>>  xen/arch/arm/domain_build.c | 38 ++++++++++++++++++++++++++++++++++++-
>>  xen/arch/arm/setup.c        | 29 +---------------------------
>>  xen/include/asm-arm/setup.h |  2 +-
>>  3 files changed, 39 insertions(+), 30 deletions(-)
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 374bf655ee..359957dc1b 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -21,6 +21,7 @@
>>  #include <asm/device.h>
>>  #include <asm/kernel.h>
>>  #include <asm/setup.h>
>> +#include <asm/tee/tee.h>
>>  #include <asm/platform.h>
>>  #include <asm/psci.h>
>>  #include <asm/setup.h>
>> @@ -2520,7 +2521,7 @@ void __init create_domUs(void)
>>      }
>>  }
>>  -int __init construct_dom0(struct domain *d)
>> +static int __init construct_dom0(struct domain *d)
> 
> This wants a sentence in the commit message. How about the following commit 
> message:
> 
> "
> Move dom0 create and start from setup.c to a dedicated function in 
> domain_build.c.
> 
> With this change, the function construct_dom0() is not used outside of 
> domain_build.c anymore. So it is now a static function.
> 
> No functional changes intended.
> "
> 
> If you agree with the new commit message. I can modify while commiting it:

Hi Julien, yes I agree, since I have to push a v4, I can add the modifications 
above in that

Cheers,
Luca

> 
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Cheers,
> 
> -- 
> Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.