[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 1/2] x86/vtx: add LBR_SELECT to the list of LBR MSRs


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Date: Wed, 14 Apr 2021 05:40:21 +0100
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <roger.pau@xxxxxxxxxx>, <wl@xxxxxxx>, <jun.nakajima@xxxxxxxxx>, <kevin.tian@xxxxxxxxx>, "Igor Druzhinin" <igor.druzhinin@xxxxxxxxxx>
  • Delivery-date: Wed, 14 Apr 2021 04:40:41 +0000
  • Ironport-hdrordr: A9a23:Ttdt3qjW/o1SnGJ0iTiE/iURAHBQXh0ji2hD6mlwRA09T+Wzva mV/cgz/xnylToXRTUcicmNUZPwJ0/02JZp7eAqTNSfdSb8vm/AFu5fxK/D5xGlJCHk7O5a0s 5bAs9DIfn9F0Jzg8q/wCTQKadD/PC9/KqlhfjTwh5WJGkAAcwN0y5DBhuGCUozfQFaBPMCZf 6hz/BarDmtc2l/VKSGL0QCNtKsm/T70LbvYRsLHHccmWyzsQ8=
  • Ironport-sdr: djWu51CvWjQpY1Dj6+TdW2d2chcqBa7C2Ghh4p1tM5igYwWCBWzVCSwiiUiJ3fccrsiLrnrEuh o88TBJyWoaIXsmxZ3XDjnTZBepi3PDOBveUY3S+DGkHG+dGjSu285VfkF5uqIaDjDKGQ6PVAw7 7uLYfZfrv3wHzGTrNkNxjQwv/funbN+fw4riVAJECke2V0r+1ABAR096U1xtQNnUzKqDtgB1hd qXRVRkmIX/WPepbF0L4AYSrroAhhvDBhrcdxoI/9rt/d8FkoI0WsgwUbTfKaHhvLEdc1DPhsUw 1tU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

This MSR exists since Nehalem and is actively used by Linux, for instance,
to improve sampling efficiency.

Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
---
New patch in v4 as suggested by Andrew.
---
 xen/arch/x86/hvm/vmx/vmx.c      | 7 +++++--
 xen/include/asm-x86/msr-index.h | 6 +++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 835b905..5a4ca35 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2915,14 +2915,16 @@ static const struct lbr_info {
 }, nh_lbr[] = {
     { MSR_IA32_LASTINTFROMIP,       1 },
     { MSR_IA32_LASTINTTOIP,         1 },
-    { MSR_C2_LASTBRANCH_TOS,        1 },
+    { MSR_NHL_LBR_SELECT,           1 },
+    { MSR_NHL_LASTBRANCH_TOS,       1 },
     { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO },
     { MSR_P4_LASTBRANCH_0_TO_LIP,   NUM_MSR_P4_LASTBRANCH_FROM_TO },
     { 0, 0 }
 }, sk_lbr[] = {
     { MSR_IA32_LASTINTFROMIP,       1 },
     { MSR_IA32_LASTINTTOIP,         1 },
-    { MSR_SKL_LASTBRANCH_TOS,       1 },
+    { MSR_NHL_LBR_SELECT,           1 },
+    { MSR_NHL_LASTBRANCH_TOS,       1 },
     { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH },
     { MSR_SKL_LASTBRANCH_0_TO_IP,   NUM_MSR_SKL_LASTBRANCH },
     { MSR_SKL_LASTBRANCH_0_INFO,    NUM_MSR_SKL_LASTBRANCH },
@@ -2937,6 +2939,7 @@ static const struct lbr_info {
 }, gm_lbr[] = {
     { MSR_IA32_LASTINTFROMIP,       1 },
     { MSR_IA32_LASTINTTOIP,         1 },
+    { MSR_GM_LBR_SELECT,            1 },
     { MSR_GM_LASTBRANCH_TOS,        1 },
     { MSR_GM_LASTBRANCH_0_FROM_IP,  NUM_MSR_GM_LASTBRANCH_FROM_TO },
     { MSR_GM_LASTBRANCH_0_TO_IP,    NUM_MSR_GM_LASTBRANCH_FROM_TO },
diff --git a/xen/include/asm-x86/msr-index.h b/xen/include/asm-x86/msr-index.h
index 43d26ef..25c4308 100644
--- a/xen/include/asm-x86/msr-index.h
+++ b/xen/include/asm-x86/msr-index.h
@@ -606,14 +606,18 @@
 #define NUM_MSR_C2_LASTBRANCH_FROM_TO  4
 #define NUM_MSR_ATOM_LASTBRANCH_FROM_TO        8
 
+/* Nehalem (and newer) last-branch recording */
+#define MSR_NHL_LBR_SELECT             0x000001c8
+#define MSR_NHL_LASTBRANCH_TOS         0x000001c9
+
 /* Skylake (and newer) last-branch recording */
-#define MSR_SKL_LASTBRANCH_TOS         0x000001c9
 #define MSR_SKL_LASTBRANCH_0_FROM_IP   0x00000680
 #define MSR_SKL_LASTBRANCH_0_TO_IP     0x000006c0
 #define MSR_SKL_LASTBRANCH_0_INFO      0x00000dc0
 #define NUM_MSR_SKL_LASTBRANCH         32
 
 /* Goldmont last-branch recording */
+#define MSR_GM_LBR_SELECT              0x000001c8
 #define MSR_GM_LASTBRANCH_TOS          0x000001c9
 #define MSR_GM_LASTBRANCH_0_FROM_IP    0x00000680
 #define MSR_GM_LASTBRANCH_0_TO_IP      0x000006c0
-- 
2.7.4




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.