[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 2/2] x86/intel: insert Ice Lake-SP and Ice Lake-D model numbers


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Date: Wed, 14 Apr 2021 05:40:22 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <roger.pau@xxxxxxxxxx>, <wl@xxxxxxx>, <jun.nakajima@xxxxxxxxx>, <kevin.tian@xxxxxxxxx>, "Igor Druzhinin" <igor.druzhinin@xxxxxxxxxx>
  • Delivery-date: Wed, 14 Apr 2021 04:40:41 +0000
  • Ironport-hdrordr: A9a23:xH0SwaF54esV1gIqpLqEcMeALOonbusQ8zAX/mpaICY1TuWzkc eykPMHkSLlkTp5YgBZpfmsMLSNKEmslqJdzpIWOd6ZMzXOmGztF4166Jun/juIIVybysd49Y NNN5dzE8fxC18St7eC3CCdH8w7yNeKtICE7N2urUtFdg1hZ6F+4woRMG/yeScaKDVuPpY3GI GR4cBKvVObCBMqR/+2G2UfWKz7r8DL/aiWByIuPQIt6wWFkFqTiILSLh7w5HkjegIK5b8j9G Tf+jaJg5mejw==
  • Ironport-sdr: 737Ffi+JJYFgEfAHj89YiBMDJcHHWopOzx2QAzBzEYVYuERuevmS4FCbVlZVPcKDDiQDEXxfGs c05mWqIzszKRlSxMpP+qyd4ROqUZLfSZDEd/B7n76grfrwanydu4yhOIbra5kgXyMLWDsVw2fu zzqrRqJJow+rN0tYb2Su6L7lgvEAzo0JAbV3en9eKBHBqkjhsSyjjKT5GwnIsh4qbqyLukEO3o CD6G7CKSj83AWxZxEUQifzz6tOT3Xc3jOWronToEvF/94K4a4VoBKsK9CMJd3Vm0sho6aGwdL3 zsU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

LBR, C-state MSRs should correspond to Ice Lake desktop according to
SDM rev. 74 for both models.

Ice Lake-SP is known to expose IF_PSCHANGE_MC_NO in IA32_ARCH_CAPABILITIES MSR
(as advisory tells and Whitley SDP confirms) which means the erratum is fixed
in hardware for that model and therefore it shouldn't be present in
has_if_pschange_mc list. Provisionally assume the same to be the case
for Ice Lake-D while advisory is not yet updated.

Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
---
Changes in v4:
- now based on SDM update
- new LBR (0x1e0)does not seem to be exposed in the docs

Changes in v3:
- Add Ice Lake-D model numbers
- Drop has_if_pschange_mc hunk following Tiger Lake related discussion
---
 xen/arch/x86/acpi/cpu_idle.c | 2 ++
 xen/arch/x86/hvm/vmx/vmx.c   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c
index c092086..d788c8b 100644
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -181,6 +181,8 @@ static void do_get_hw_residencies(void *arg)
     case 0x55:
     case 0x5E:
     /* Ice Lake */
+    case 0x6A:
+    case 0x6C:
     case 0x7D:
     case 0x7E:
     /* Tiger Lake */
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 5a4ca35..52469ca 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -2982,7 +2982,7 @@ static const struct lbr_info *last_branch_msr_get(void)
         /* Goldmont Plus */
         case 0x7a:
         /* Ice Lake */
-        case 0x7d: case 0x7e:
+        case 0x6a: case 0x6c: case 0x7d: case 0x7e:
         /* Tiger Lake */
         case 0x8c: case 0x8d:
         /* Tremont */
-- 
2.7.4




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.