[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] x86/EFI: program headers are an ELF concept
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 21 Apr 2021 16:21:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXNMhF7PHwW8p7LfJN7/WLbLO09GmNA9ENeeoH4A24w=; b=hNTyos4cpLMEHqM3JqZmJ0RZwbuznynpvN7Fp+/P7Gyo9KfBMHuf0YgDtE79MadSKp6mRWiK7zeGhVhkxpd5RR1DdFLpu5OAANIAe9paz8nMxx4fz14Oy6HlpTwZKNIXxOggttouWn4FJB5APkzdFvBdljAztWlyHSu+QbsL2ULRplZB1cFGhIIBRUVnKuMLdNTtAmQ2yThRjwiK78eBiGbO07oPa7ONKUX2C8kW6lHvofOxqaGKpmsKNQcrzyx27/lXhIJNSW9OYSggx3wFjNfm627dkODf99iRdIpOo8pxXNV2/0FcYxdKB5Tlq8CEbIfIWpLMdEqYNga6SX5q4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FktSm/H+INlWSPIWaqSqVrW/ZrAGrcqM/Y3p2CrKbIg8u62V75UGxsswIWz2iVkhKXLLgfYFvpJuZghpPSVyjO9j4VM3CIruqLsfsb0baf6bC7oSx59hEPv6hhuUQggGRYyXwKOnVHbCKXrgqd5a97593uQ9q3TZTMm427oqz6Wnua1FsNnBp6m/Y9zEN+5Bx5Tb2yTvnySw1BLLus1f4Nv2iyH8ITyCqxLOj0244dYmMur3DX9a9fJLUY8cbe0V3DWMWATZ4p/vvrFQSixAamrJeAiiTurn6DvRfbGhaLdsgFBH1mzBDyibzqk1atuqi/zirQwErM9EQFUbNkBSWA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 21 Apr 2021 14:21:41 +0000
- Ironport-hdrordr: A9a23:0+2x9Kp0FZZ/remUWRczDKIaV5v5L9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyFJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFaSFPR+Ve4xxiCgCde3cGITVuIZYiDp KT6o5milObCBcqR/+2DHUEQOTPzuej/P7bSCULGgI97022hS6ogYSQLzGjwhwcXzlTqI1Sk1 TtrgqR3MSemsD+8DDw/Sv575NamNzuo+EzefCku4wuBRjHziqtbIRlcbWesD4yu/HH0idXrP D85y0OEu42x3TNfnykgRaF4Xie7B8er0XM5HXdoXz/rdf3TDg3YvAx+75xQ1/ixGcL+PRfuZ g7uF6xht5sIj7r2BnZ3ZzuUSpnk0KlyEBS6tI7vjhkfqY1LINKoZd3xjIyLL4wWBjUxaoAC+ dUAMTV9J9tACmnRkGchGVpzdC2N05DZyuucwwHssyR5TBcgGp0+Use3NAehXcN7vsGOuF529 g=
- Ironport-sdr: S0ZVkX7sAUrZuJdblNpPb2NTH1WLzX8cHcZEhv2y0+BiLnZI+XE8aWO3b7EfCHivZ+ZOzA28Sd lIVzRHQqL8JF5VvqvWMrxFbmN9LXW69uJGbflD2Gqm0I2nm8Lg2EXkR+K2MROPqfW7Kyt4VLZR BYW9rR0LWisppakIVeYx2VJmhN1EcLpTBnGWtI8WYSoiBSVa4E8jw1UJcVi8LeB2LEfjx7moHO WIcExqPv4jnANM6slHjisZAx/jEwabMOqRiBoXbXgyJ2WYqeEpH8oOGlH9YuS7WQ56e746gzrg ZVU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Apr 21, 2021 at 12:36:16PM +0200, Jan Beulich wrote:
> On 21.04.2021 11:11, Roger Pau Monné wrote:
> > On Thu, Apr 01, 2021 at 11:45:09AM +0200, Jan Beulich wrote:
> >> While they apparently do no harm when building xen.efi, their use is
> >> potentially misleading. Conditionalize their use to be for just the ELF
> >> binary we produce.
> >>
> >> No change to the resulting binaries.
> >
> > The GNU Linker manual notes that program headers would be ignored when
> > not generating an ELF file, so I'm not sure it's worth us adding more
> > churn to the linker script to hide something that's already ignored by
> > ld already.
> >
> > Maybe adding a comment noting program headers are ignored when not
> > generating an ELF output would be enough?
>
> Maybe, but I'd prefer this to be explicit, and I'd prefer for efi.lds
> to not have any PE-unrelated baggage. The churn by this patch isn't
> all this significant, is it? In fact in two cases it actually deletes
> meaningless stuff.
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I would prefer if the new PHDR macro was used for all program headers
directives for consistency though.
Thanks, Roger.
|
