[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] x86/EFI: sections may not live at VA 0 in PE binaries
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 23 Apr 2021 16:25:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sfm4ssBaOeWSpdHGRGVPJvZoS75dUVH/0fI5rRbpWNs=; b=OX520V4rguok+FgA5+3yDTyxSfYNv66vhn4OroXnBUc6ollqf1TQ6W/GkjkW6SoT3w51XRTkC86NNHPdm4ojnPah1/gO76fELIUY3NWBE+QqqzZEdWoULfHL+1ryqwOYeS9xbMfcM0MscgjwXnxf5pIyPOI9L+Xli9Gi1oIPZdgXmdWJ/CdMjtIKX20SNPHg1ETjRhCgLGw/+JGgtAuu4Cncr/H/koryRZh1l8Osp7Bb4lHfj8o4AO7rKtrWtaibM45vOU7ho1cs3Cndbn/T9vt2jR6x138q3eegkjMM7PC8LyukLKsi99P5/+TMmLFQ0joYId8yJs+xNhDQIm4hVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0gLkn5PgUbgl0590iIPHLu2lzoz6P+5bC+ux0l1+tnmn+q+MaEIVV/mC7K6nVyVbGyDB5jyQweGAGWcaxTx/uUXtNcAZNSXjYeZTV8s8peHhKwkIhtc1L5vXIQbMyXlQKogNmBpc6B5rpswP3/V0F8qM4q0uX4GroheQrtrCF4McJ3sPId2CiQ+nQI+Q/bUgNDy9ZlNPYSsvFg01Toyf5ClPQ34byOO4kwee4u5U97eZqivcVqow+bfyWscaJB3UacMPeAL0ebHdzwPIeXRBYd7kcdVKFnbVJJH6OKHOp4YjoeHXL1+rL5Q24LOmTAnqPbuggfMVQIdkh8CzFWRww==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 23 Apr 2021 14:26:07 +0000
- Ironport-hdrordr: A9a23:EFoxNaFUQgzQ5FNwpLqEE8eALOonbusQ8zAX/mp2TgFYddHdqt C2kJ0gpHzJoRsyeFVlo9CPP6GcXWjRnKQf3aA9NaqvNTOGhEKGN4dnhLGM/xTFOwnTstFQzr 1hda8WMrHNJHx3l9zz7gX9M/tI+qjkzImSie3Tz2hgQGhRAskLgjtRMBqREUF9WWB9ZaYRKZ z03KR6jgvlX28WYMS9DnwsRPPCuNXPqZLjbXc9dnsa1DU=
- Ironport-sdr: quruP4DxeK9B4T2dDPACinPZ7FdXOLxqfXOJAksCyyaaXXFg5h4l/lpSdD0xtylNL6mX2jJQBv 1xUXBbau/0yKjvGJ0XJo6xAtvnWArXDiylHCLxOhtSqmpcEtUMfI7HVAuBqJaqHvaex6c+BPa+ ifvl+oHUG+bP4oB16Kw3Z6QM2W/q6/IJlf1nOk4z28zns1KEZZjcKe7/yFdD8xZd/5q5LKEb0d /fccfr6heVAFL1r2tDdcRTPaS24/aclAe9NzZsHLgzkLYSNdr1YzMFPKBYlloqkOrnPuFFuuj1 8YM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Apr 23, 2021 at 01:03:34PM +0200, Jan Beulich wrote:
> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at
> least 2.36 would silently truncate the (negative) difference when a
> section is placed below the image base. Such sections would also be
> wrongly placed ahead of all "normal" ones. Since, for the time being,
> we build xen.efi with --strip-debug anyway, .stab* can't appear. And
> .comment has an entry in /DISCARD/ already anyway in the EFI case.
>
> Because of their unclear origin, keep the directives for the ELF case
> though.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Albeit I would remove those - even if gcc can still generate stabs
debug info I don't think it's used at all, and in any case a user
would have to also modify the build system in order to force gcc to
produce stabs debug info.
Thanks, Roger.
|
