[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] x86/EFI: keep debug info in xen.efi


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 23 Apr 2021 16:27:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CPfYXvC9KnrUd2ufBg/2YkRNJLaVKSAarwCjwPpLm7U=; b=GJ/Ks4OmfouO72VMy81VmPjgKzBxUGVh+REMhDTaYCdC58VGzvGc/af0WajDT7dojUw1SnKkBHn2xmEeoZQAAWC+n0qfjjIvyuIBhDytuKYhFo70NSJtjj/M3RffJYzM3XN35QF8DtiQzEjBAT44lh6oaRxwBG0X9NtvZk916famcFOLg3etjabrAZDAAs64ZkCFEQfnL3J3vKLP9uoMAYo/eUW9EbJrgnCp8ru5bZw0ZF4/+w9KkB/xX6FUeo/BlNAOneDpS/dCgCCO4M/lpIGIkzMjvXS1yWzJLNfJysrA0gtsr5cFI8FEQYuzWs1IbsagUwTD0ddjvdh4HKd8Ww==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JhgwOIZgh6nUp/BEnjU/a/SM8kXdUpHydVAInSC3nohbb+GITrsiRj792VgDulKwtZoV2ahsQZ+onvv+Jk9Eg9N6mtQWTE9bI6ok1p7SUKQMY1xstZkMX3i89PtCvzg13Nh8fgN5PqkncueyvR4JEcQxowp6qUijhSaD7BPYA7KuvmkzS3xCy92PorWLf8dXL07zikwBJBZhH0+WEvNpkcQtukCIkr3TsmQnliywz+6hTOZABTaMPPI3iMOZOQxTc1tfZrX6+4RuAc7r8pbkCB9gVLuxliNAr/Tlz+S3EGg/CZTjzRTInvrxKujJ009V3UdUcBdWwHbP0lpSWm2A0A==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 23 Apr 2021 14:27:21 +0000
  • Ironport-hdrordr: A9a23:Qe9De6McmJsQbsBcTxP155DYdL4zR+YMi2QD/1xtSBBTb8yTn9 2vmvNe7hPvlDMNQhgb9OyoEqPoexPh3LRy5pQcOqrnYRn+tAKTXeVfxKbB4xmlIS3x8eZByb xtGpIVNPTcBUV35PyU3CCWCNAlqePozImNpcPzi0hgVhtrbaYI1XYdNi++HldtTAdLQboVfa DshfZvnDardXQJYsnTPBBsM9TrnNHXiIngJScPGh9P0mKzpAm14733GQXw5GZ9bxpzx94ZkF TtokjCyYiI99q6zRLd0GG71eUqpPLRjuFtKebJpswcKjDHghulaoJ7S9S5zUwIidDq0nkGup 3hpAohItRS5hrqDx6IiCqo4SbM+nIP7GLv0lCRi3eLm72GeBsKT/BvqKgcVzmx0TtGgPhMlJ hl8kjcir9sSTTHpyj578igbWAQqmOE5UAMvMRWs2ZSSuIlGdlshL1axmx5OrEaEhn37Yg2ed Medv301bJtfVSWY2uxhBgX/PWcGnA6HhKxSkMfoMCi0z9PgHBjz0cDrfZv5ks9yA==
  • Ironport-sdr: 2vrnpsA43HwWzB7E+eiz899IccBTAiOjYgb9p3R7wNXFA1XgVbEF3uPPjDpzi6e7XiWv7Yql45 QAetlavORbszwAeFTzdDfRNhlr4d72/QEjAyzgfAE/ijY2b9LRxkGUjxUz4V9itH02lYK5dzKe uNEP8JqytTEG20EIIrlVQyICVNikE2o/87RVU31DS22NRvP3CmpfYwoLdI3szQ/wGDLSCmF06u I+xT88sUxIv0pNj+NiPMlKoyodCBYFLn5R02paXDt22ZG+B3Ibc6FbfW/cQd/K2lBvBMFVq8KQ xFU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Apr 23, 2021 at 01:04:10PM +0200, Jan Beulich wrote:
> ... provided the linker supports it (which it does as of commit
> 2dfa8341e079 ["ELF DWARF in PE output"]).
> 
> Without mentioning debugging sections, the linker would put them at
> VA 0, thus making them unreachable by 32-bit (relative or absolute)
> relocations. If relocations were resolvable (or absent) the resulting
> binary would have invalid section RVAs (0 - __image_base__, truncated to
> 32 bits). Mentioning debugging sections without specifying an address
> will result in the linker putting them all on the same RVA. A loader is,
> afaict, free to reject loading such an image, as sections shouldn't
> overlap. (The above describes GNU ld 2.36 behavior, which - if deemed
> buggy - could change.)
> 
> Make sure our up-to-16Mb padding doesn't unnecessarily further extend
> the image.
> 
> Take the opportunity and also switch to using $(call ld-option,...).
> 
> Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.